Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated system test execOptions #30478

Merged
merged 2 commits into from
Nov 1, 2024
Merged

chore: remove deprecated system test execOptions #30478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
080cd2e
chore: remove deprecated system test execOptions
jennifer-shehane Oct 28, 2024
27f511b
empty commit
jennifer-shehane Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions system-tests/lib/system-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,16 +79,6 @@ type ExecOptions = {
* If set, test using the built Cypress CLI and binary. Expects a built CLI in `/cli/build` and packed binary in `/cypress.zip`.
*/
withBinary?: boolean
/**
* Deprecated. Use `--cypress-inspect-brk` from command line instead.
* @deprecated
*/
inspectBrk?: null
/**
* Deprecated. Use `--no-exit` from command line instead.
* @deprecated
*/
exit?: null
/**
* Don't exit when tests are finished. You can also pass `--no-exit` via the command line.
*/
Expand Down Expand Up @@ -629,14 +619,6 @@ const systemTests = {
},

options (ctx, options: ExecOptions) {
if (options.inspectBrk != null) {
throw new Error(`
passing { inspectBrk: true } to system test options is no longer supported
Please pass the --cypress-inspect-brk flag to the test command instead
e.g. "yarn test async_timeouts_spec.js --cypress-inspect-brk"
`)
}

_.defaults(options, {
browser: process.env.SNAPSHOT_BROWSER || 'electron',
headed: process.env.HEADED || false,
Expand All @@ -648,19 +630,10 @@ const systemTests = {
sanitizeScreenshotDimensions: false,
normalizeStdoutAvailableBrowsers: true,
noExit: process.env.NO_EXIT,
inspectBrk: process.env.CYPRESS_INSPECT_BRK,
})

const projectPath = Fixtures.projectPath(options.project)

if (options.exit != null) {
throw new Error(`
passing { exit: false } to system test options is no longer supported
Please pass the --no-exit flag to the test command instead
e.g. "yarn test async_timeouts_spec.js --no-exit"
`)
}

if (options.noExit && options.timeout < 3000000) {
options.timeout = 3000000
}
Expand Down Expand Up @@ -770,10 +743,6 @@ const systemTests = {
args.push('--no-exit')
}

if (options.inspectBrk) {
args.push('--inspect-brk')
}

if (options.tag) {
args.push(`--tag=${options.tag}`)
}
Expand Down
Loading