chore: add graphql schema update and wrap process.kill to swallow ESRCH error #30434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch error [run ci]
AtofStryker
changed the title
ryanthemanuel
approved these changes
Oct 21, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Noticed this error shows up from time to time in open mode in firefox. This has to do with
process.killbeing called with a process that doesn't exist. Since we can assume the process we are trying to kill has already been killed, we can swallow this error. Also added theFIREFOX_CDP_FAILED_TO_CONNECTto the graphql schema which I missed in #30393Also adds the
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?