-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client certificate selector option during e2e tests #30203
feat: client certificate selector option during e2e tests #30203
Conversation
Added an extra certificate filter when certificate is chosen for requests based on groups, This can be used to tackle the problem of testing multiple certificate cases for the same URL. Needs review and feedback.
|
@alienkarma We would need tests to cover this new behavior in order to accept this PR. Can you add those? |
…g, fixed ts errors on spec file and added relevant tests
Hi |
…ports and error messages and fixed client certificate bug
…iple-certificates-selectCert" and test "multiple_certificates_selectCert" Note: Certs folder unfortunately has to be added to prevent start up errors in referencing the certificates
Hi @jennifer-shehane |
Added the relevant docs - cypress-io/cypress-documentation#5922 |
I think the |
Hi @jennifer-shehane |
Hi @jennifer-shehane |
@alienkarma Let me run the tests and see if someone can pick up review in this sprint. |
@alienkarma Hey, we appreciate the time you put into this PR. The team did take a look over the intentions and implementation of the PR. There are a few implementation details that differ from our desired goal for this functionality.
Coding these changes would be quite a rewrite and quite complex to have working across browsers. Right now we don't have the capacity to focus on this rewrite and would recommend closing this PR at this time. Sorry for the lack of communications upfront - we do appreciate your shedding more light on this problem to our team. |
Hi @jennifer-shehane |
Additional details
Added an extra certificate filter when certificate is chosen for requests based on groups.
This can be used to tackle the problem of testing multiple certificate cases for the same URL.
Needs review and feedback.
Implementation
Certificates will be marked with a group tag as below in config:-
And then intended to be swapped using
cy.chooseCert(group_name)
during tests. (Null or empty can be provided for resetting the certificate selection)Steps to test
Need help implementing testing for this
How has the user experience changed?
Check implementation above
PR Tasks
cypress-documentation
?type definitions
?