Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Security upgrade webpack from 5.88.2 to 5.94.0 #30122

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

emilyrohrbough
Copy link
Member

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • npm/webpack-batteries-included-preprocessor/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Cross-site Scripting (XSS)
SNYK-JS-WEBPACK-7840298
  688  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Cross-site Scripting (XSS)

…ce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-WEBPACK-7840298
Copy link

cypress bot commented Aug 28, 2024

cypress    Run #56864

Run Properties:  status check failed Failed #56864  •  git commit b04dcfc187: Update protocol snapshots with new stack trace lines
Project cypress
Branch Review snyk-fix-c603ef5968f6798883d404a5e75181bf
Run status status check failed Failed #56864
Run duration 15m 31s
Commit git commit b04dcfc187: Update protocol snapshots with new stack trace lines
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 8
Tests that did not run due to a developer annotating a test with .skip  Pending 1328
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29395
View all changes introduced in this branch ↗︎
UI Coverage  44.92%
  Untested elements 201  
  Tested elements 168  
Accessibility  91.2%
  Failed rules  5 critical   10 serious   2 moderate   2 minor
  Failed elements 948  

Tests for review

Failed  src/debug/DebugPageHeader.cy.tsx • 1 failed test • app-ct

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay
Flakiness  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > past Max-Age, before Expires -> not logged in
    </td>
  </tr></table>
Flakiness  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin - cookie login > Max-Age > past max-age -> not logged in Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
network stubbing > waiting and aliasing > yields the expected interception when two requests are raced Test Replay
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/56864/overview/74b73899-b120-4c50-9152-b370a5f79290?reviewViewBy=FLAKY&utm_source=github&utm_medium=failed&utm_campaign=view%20test">
        ... > with `resourceType` > can match a proxied image request by resourceType
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/56864/overview/e20e3745-e07e-41d6-beb0-78ea329ab04c?reviewViewBy=FLAKY&utm_source=github&utm_medium=failed&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

@jennifer-shehane jennifer-shehane changed the title [Snyk] Security upgrade webpack from 5.88.2 to 5.94.0 chore: Security upgrade webpack from 5.88.2 to 5.94.0 Aug 28, 2024
@jennifer-shehane jennifer-shehane self-assigned this Aug 28, 2024
@jennifer-shehane jennifer-shehane self-requested a review August 28, 2024 15:19
@@ -46,7 +46,7 @@ exports['e2e events'] = `
"line": 1,
"column": 0,
"whitespace": " ",
"stack": "Error\\n at eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:9:1)\\n at eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:33:12)\\n at eval (<anonymous>)"
"stack": "Error\\n at eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:8:1)\\n at eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:32:12)\\n at eval (<anonymous>)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why these stack trace lines require updating. Assume it's a fix?? 😬

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webpack changelog: https://github.com/webpack/webpack/releases

I believe we'll need to trigger a release for the package separately as we always do since some other files needed to be touched.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more updates needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants