Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visibility issue with parent absolute #29689

Merged
merged 43 commits into from
Dec 2, 2024

Conversation

senpl
Copy link

@senpl senpl commented Jun 17, 2024

Additional details

  • Fixed visibility issue when the element is position static or relative, and the element's offset parent is positioned absolute, a descendent of the ancestor, and has no clippable overflow.

Steps to test

See new tests for scenarios.

How has the user experience changed?

Before:
Screenshot 2024-11-25 at 6 12 04 PM

After:
Screenshot 2024-11-25 at 6 12 26 PM

PR Tasks

@cypress-app-bot
Copy link
Collaborator

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tests failing here. Can you please address those?

@senpl
Copy link
Author

senpl commented Jun 26, 2024

Unit test -Delegate cloud is probably not related.
Integrated works except Firefox. I will check it when I will find time.

cli/CHANGELOG.md Outdated Show resolved Hide resolved
@senpl
Copy link
Author

senpl commented Jul 1, 2024

Now looks like pipeline fail on unrelated certificate.

@senpl senpl requested a review from jennifer-shehane July 1, 2024 10:01
@jennifer-shehane
Copy link
Member

@senpl There are still failures here that need addressing. Please check the test files locally before committing, to ensure they pass.

@senpl
Copy link
Author

senpl commented Jul 8, 2024

All tests passed. What else is needed ???

@jennifer-shehane
Copy link
Member

We've decided to prioritize looking into these visibility fixes in Quarter 4 of this year, when we intend to spend time on Cypress 14 release. It will ease any concerns we have around releasing breaking changes with these fixes and also help us plan the proper time to review these. Tracking here: #29925

@jennifer-shehane jennifer-shehane marked this pull request as draft August 14, 2024 15:14
@jennifer-shehane jennifer-shehane removed their request for review August 15, 2024 14:02
@jennifer-shehane jennifer-shehane added the Cypress 14 Issues scoped for Cypress 14 label Sep 27, 2024
@senpl senpl marked this pull request as ready for review September 30, 2024 10:16
@jennifer-shehane jennifer-shehane changed the base branch from develop to release/14.0.0 September 30, 2024 15:29
@jennifer-shehane jennifer-shehane requested review from mschile and removed request for jennifer-shehane November 13, 2024 16:04
@mschile mschile changed the title fix: 28638 parent absolute fix: visibility issue with parent absolute Nov 26, 2024
@jennifer-shehane jennifer-shehane dismissed their stale review November 27, 2024 00:47

Dismissing my previous review

cli/CHANGELOG.md Outdated Show resolved Hide resolved
@mschile mschile merged commit d8d493a into cypress-io:release/14.0.0 Dec 2, 2024
3 of 6 checks passed
@jennifer-shehane jennifer-shehane mentioned this pull request Dec 3, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cypress 14 Issues scoped for Cypress 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants