-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update visibility for elements with textContent but without width/height #29688
Conversation
|
It was done similar in the past as could be seen in #5974 |
One test updated because element that was in test in fact was visible, and incorrectly exected to be hidden and not visible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@senpl There a failure regarding visibility in the tests.
Now looks like cert errors, so probably something with pipeline. |
Updated the base branch to go against release/14.0.0 |
I'll leave some notes here on where I left off on this. Essentially, there are some circumstances where elements should be considered visible/hidden depending on the state of their child node that is a TEXT node. And Cypress is not taking those situations into account today.
^ this last part in highlighted text is not currently being accounted for in the logic, which is why there is a failing test. I'm not sure if there are other circumstances that this updated code doesn't account for. Essentially the Cypress logic never seemed to be taking into account TEXT nodes, we've only been accounting for actual element nodes. |
Dismissing previous review.
Additional details
textContent
.Steps to test
See new tests for scenarios.
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation
?type definitions
?