fix: regression with requests with a status of 304

[ryanthemanuel]

• Closes Cached (status 304) requests may take longer than they used to #28295

Additional details

This fix undoes the changes implemented in #28217. Those changes ended up having a wider impact that we originally thought and so we are undoing them while we find a better solution.

Steps to test

n/a

How has the user experience changed?

Performance can improve if you have rather large assets that are cached between tests in a spec

PR Tasks

• Have tests been added/updated?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress]

24 flaky tests on run #52232 ↗︎

0

28268

1346

0

24

Details:

Merge branch 'develop' into ryanm/fix/issue-with-cached-requests
Project: cypress	Commit: 8096ce3e9d
Status: Passed	Duration: 19:45 💡
Started: Nov 9, 2023 6:42 PM	Ended: Nov 9, 2023 7:01 PM

  e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron

View
Output

Test		Artifacts
user agent override > persists modified user agent after cy.go		Test Replay

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View
Output

Test		Artifacts
... > correctly returns currentRetry		Test Replay
... > correctly returns currentRetry		Test Replay
... > correctly returns currentRetry		Test Replay

  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View
Output

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		Test Replay Screenshots

  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View
Output

Test		Artifacts
cy.origin assertions > #consoleProps > .should() and .and()		</td> </tr></table>   cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox View Output Test Artifacts ... > correctly returns currentRetry </td> </tr> <tr> <td colspan="2"> <a href="https://cloud.cypress.io/projects/ypt4pf/runs/52232/overview/14a33223-3edf-4873-865a-1d035da098ad?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test"> ... > correctly returns currentRetry </a> </td> <td> </td> </tr> <tr> <td colspan="2"> <a href="https://cloud.cypress.io/projects/ypt4pf/runs/52232/overview/7850c1e6-a747-4a85-a5a6-0a9da6013895?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test"> ... > correctly returns currentRetry </a> </td> <td> </td> </tr></table> The first 5 flaky specs are shown, see all 11 specs in Cypress Cloud. Review all test suite changes for PR #28296 ↗︎