feat: display artifact upload durations in the console #28226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 flaky tests on run #52309 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > displays each run with correct information |
Test Replay
Screenshots
|
|
| ... > opens the run page if a run is clicked |
Test Replay
Screenshots
|
|
cypress-in-cypress.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config |
Test Replay
Screenshots
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #28226 ↗︎
mschile
reviewed
Nov 3, 2023
| @@ -338,7 +345,8 @@ const uploadArtifactBatch = async (artifacts, protocolManager, quiet) => { | |||
| return skipped && !report.error ? acc : { | |||
| ...acc, | |||
| [key]: { | |||
| ...report, | |||
| // TODO: once cloud supports reporting duration, no longer omit this | |||
| ..._.omit(report, 'duration'), | |||
There was a problem hiding this comment.
Is the Cloud not able to handle extra fields?
There was a problem hiding this comment.
No, it will give zod errors.
mschile
reviewed
Nov 3, 2023
* feat(webpack-dev-server): add support for angular 17 * update changelog * fix broken spec pattern * update to rc 2 for cli * remove = from dependency minVersion lists * update angular 17 rc version and update dep test * add projectDirFolder to fixtures for angular-17 * resolve broken system tests * update ct project dir angular version
ryanthemanuel
approved these changes
Nov 13, 2023
mschile
reviewed
Nov 14, 2023
mschile
reviewed
Nov 14, 2023
| @@ -111,7 +111,7 @@ exports['video compression true / compresses to 32 CRF'] = ` | |||
|
|
|||
| (Uploaded Cloud Artifacts) | |||
|
|
|||
| - Video - Done Uploading 1 kB 1/1 /XXX/XXX/XXX/cypress/videos/video_compression.cy.js.mp4 | |||
| - Video - Done Uploading 1 kB 1/1 in Xm, Ys ZZms /XXX/XXX/XXX/cypress/videos/video_compression.cy.js.mp4 | |||
There was a problem hiding this comment.
Looks like the snapshot needs to be updated to reflect the updates.
There was a problem hiding this comment.
Updated, thanks for the catch!
| process.stdout.write(` ${success ? 'in' : 'after'} ${durationOut}`) | ||
| } | ||
|
|
||
| process.stdout.write(` ${num}`) |
There was a problem hiding this comment.
what is num in this context?
There was a problem hiding this comment.
1/2, 2/2, etc. carryover name from previous logic
mschile
approved these changes
Nov 16, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Test Replay capture artifacts can be fairly large, so it is important to display how long it takes to upload artifacts to the Cypress cloud when recording a run. Each artifact type (screenshots, video, test replay) now displays how long it took to upload after the upload is complete. If an artifact fails to upload, the duration of the request is displayed as well.
Steps to test
Record a test run that will produce artifacts that are uploaded to the cloud, and observe the duration in the console output.
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?