Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removed the comma as mentioned #28002

Closed
wants to merge 3 commits into from
Closed

docs: removed the comma as mentioned #28002

wants to merge 3 commits into from

Conversation

abhisar-yadav
Copy link
Contributor

@abhisar-yadav abhisar-yadav commented Oct 7, 2023

linked to pr number #27988
I removed the comma

@cypress-app-bot
Copy link
Collaborator

@abhisar-yadav abhisar-yadav changed the title Abhisar yadav patch 1 docs: removed the comma as mentioned Oct 7, 2023
@MikeMcC399
Copy link
Contributor

@abhisar-yadav

  • This PR now duplicates PR docs: update code of conduct #27988

  • You should close one of these PRs. Normally if changes are needed in a PR you would not create a new PR. Instead you would make changes to the existing PR. You should not have two different PRs open at the same time on the same subject.

If this is your first time contributing to an open source project you may benefit from some of the online training available, for instance https://docs.github.com/en/get-started/onboarding/getting-started-with-your-github-account#part-6-participating-in-githubs-community.

Perhaps also the specific course https://github.com/skills/review-pull-requests would be helpful?

Also there is a Cypress online community available in Discord chat (click on button)

@abhisar-yadav
Copy link
Contributor Author

yes I am a beginner in the world of Open Source

@MikeMcC399
Copy link
Contributor

@abhisar-yadav

yes I am a beginner in the world of Open Source

The original source of the CODE_OF_CONDUCT on https://github.com/EthicalSource/contributor_covenant links says:

If you're new to contributing to projects hosted on Github, or need a refresher,
you may find How to make your first pull request on GitHub
a useful resource.

In fact if you have grammatical suggestions for the source template you may like to submit your suggestions according to the contributor_covenant > CONTRIBUTING guide directly to the https://github.com/EthicalSource/contributor_covenant repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants