fix: build better-sqlite3

[ryanthemanuel]

Closes #27902
Closes #27891

Additional details

Build better-sqlite3 on centos 7 to ensure a wider range of compatibility in the binary. The approach here is to use the centos7-builder.Dockerfile as the image to use when building and then mirror the build commands used for better-sqlite3. In the wrong run, we could host this Dockerfile in docker hub and potentially have some additional optimizations, but in the spirit of getting folks fixed faster, this approach is good for now.

Steps to test

You can test this by running the binaries attached to the branches on various OS's.

How has the user experience changed?

n/a

PR Tasks

• [na] Have tests been added/updated?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress]

3 failed and 14 flaky tests on run #51540 ↗︎

3

463

19

0

14

Details:

Update cli/CHANGELOG.md
Project: cypress	Commit: 0e616ccfd0
Status: Failed	Duration: 20:43 💡
Started: Oct 9, 2023 5:36 PM	Ended: Oct 9, 2023 5:56 PM

  cypress\e2e\runs.cy.ts • 1 failed test • app-e2e

View Output Video

Test		Artifacts
... > displays each run with correct information		Test Replay Output Screenshots

  cypress\e2e\specs_list_latest_runs.cy.ts • 1 failed test • app-e2e

View Output Video

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when offline > shows offline alert then hides it after coming online		Test Replay Output Screenshots

  cypress\e2e\test-isolation.cy.ts • 1 failed test • app-e2e

View Output Video

Test		Artifacts
Test Isolation > fires events in the right order with the right arguments - open mode		Test Replay Output Screenshots

  cypress\e2e\runs.cy.ts • 4 flaky tests • app-e2e

View Output Video

Test		Artifacts
App: Runs > Runs - Cannot Find Project > opens Connect Project modal after clicking Reconnect Project button		Test Replay Output Screenshots
... > displays a list of recorded runs if a run has been recorded		Test Replay Output Screenshots
App: Runs > no internet connection > shows correct message on create org modal		Test Replay Output Screenshots
App: Runs > no internet connection > shows correct message on connect project modal		Test Replay Output Screenshots

  cypress\e2e\runner\ct-framework-errors.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test		Artifacts
Angular 13 > error conditions		Test Replay Output Screenshots
Angular 14 > error conditions		Test Replay Output Screenshots

  cypress\e2e\create-from-component.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test		Artifacts
... > Shows create from component card for React projects		Test Replay Output Screenshots
... > Can be closed with the x button		Test Replay Output Screenshots

  cypress\e2e\specs.cy.ts • 3 flaky tests • app-e2e

View Output Video

Test		Artifacts
... > shows create first spec page with scaffold and create template spec options		Test Replay Output Screenshots
... > scaffold examples > scaffolds example files when card is clicked		Test Replay Output Screenshots
... > shows No Specs page with specPattern from config		Test Replay Output Screenshots

  cypress\e2e\runner\runner.ui.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
src/cypress/runner > tests finish with correct state > no tests		Test Replay Output Screenshots

The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.

Review all test suite changes for PR #27968 ↗︎

[astone123]

Looks good!

[MikeMcC399]

@ryanthemanuel

From your comments I understood that this is intended to be a temporary measure only. That would fit with the following constraints:

The Docker image centos:7 appears to be deprecated.

According to https://hub.docker.com/_/centos

CentOS 7 has a limited remaining 8 month lifetime until June 30, 2024 (see https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/).

Strangely CentOS is not listed under https://docs.cypress.io/guides/getting-started/installing-cypress#Operating-System, which only refers to the following as being supported by Cypress

Linux Ubuntu 12.04 and above, Fedora 21 and Debian 8 (x86_64 or Arm 64-bit (x64 or arm64)) (see Linux Prerequisites down below)

[MikeMcC399]

• This PR would also close electron-rebuild better-sqlite3 deprecation warnings starting with v13.2.0 #27891 as it updates to "better-sqlite3": "8.7.0" (current latest).

[cypress-bot]

Released in 13.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.3.1, please open a new issue.