fix: correlate prerequests in order instead of reverse order #27892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
requested review from
chrisbreiding,
AtofStryker,
cacieprins,
mjhenkes and
mschile
4 flaky tests on run #51326 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > displays each run with correct information |
Test Replay
Output
Screenshots
|
|
specs_list_e2e.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > saves the filter when navigating to a spec and back |
Test Replay
Output
Screenshots
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Output
Screenshots
|
|
debug.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App - Debug Page > shows information about a failed spec |
Test Replay
Output
Screenshots
|
|
Review all test suite changes for PR #27892 ↗︎
mjhenkes
approved these changes
Sep 25, 2023
chrisbreiding
approved these changes
Sep 25, 2023
mschile
reviewed
Sep 27, 2023
| @@ -331,12 +331,14 @@ export class Http { | |||
|
|
|||
| const onError = (error: Error): Promise<void> => { | |||
| ctx.error = error | |||
| if (ctx.req.browserPreRequest) { | |||
| if (ctx.req.browserPreRequest && !ctx.req.browserPreRequest.errorHandled) { | |||
| ctx.req.browserPreRequest.errorHandled = true | |||
There was a problem hiding this comment.
Do we need a test for the errorHandled logic?
There was a problem hiding this comment.
Added: 54321fc (#27892)
mschile
approved these changes
Sep 27, 2023
ryanthemanuel
deleted the
ryanm/fix/issue-with-out-of-order-requests
branch
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Historically, the proxy correlation logic used a stack for requests that matched exactly. This was because there were several cases where items were not going through the proxy. We have since learned of the reasons these items don't go through the proxy (e.g. failed requests, cached requests, etc.). Since we can now reasonably rely on everything going through the proxy that needs to, we want to actually store the requests in a queue so that requests get matched in the order they were received. This fixes an issue we have seen in Test Replay where requests were correlated in mismatched order.
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?