Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add manifest.v3 extension for chrome #27888

Merged
merged 7 commits into from
Sep 28, 2023

Conversation

cacieprins
Copy link
Contributor

@cacieprins cacieprins commented Sep 22, 2023

  • Closes

Additional details

At some point in the future, chrome will stop supporting v2 extension manifests. Due to fundamental changes in the supported APIs for manifest v3 extensions and cross-browser support thereof, a stripped down extension solely for chrome is built with the same theme and icons as the v2 extension, but none of the control/automation logic as that is accomplished via CDP.

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review September 22, 2023 19:22
@cypress
Copy link

cypress bot commented Sep 22, 2023

32 flaky tests on run #51309 ↗︎

0 28134 1345 0 Flakiness 32

Details:

Merge branch 'develop' into cacie/chore/chrome-v3-ext
Project: cypress Commit: 8d1dca0777
Status: Passed Duration: 18:59 💡
Started: Sep 27, 2023 3:37 PM Ended: Sep 27, 2023 3:56 PM
Flakiness  migration.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
Full migration flow for each project > completes journey for migration-e2e-defaults-with-projectId Test Replay Output Screenshots
Flakiness  project-setup.cy.ts • 2 flaky tests • launchpad-e2e

View Output Video

Test Artifacts
... > can skip setup CT testing for an E2E project Test Replay Output Screenshots
Launchpad: Setup Project > switch testing types > takes the user to first step of e2e setup when switching from app Test Replay Output Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
Flakiness  e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
user agent override > persists modified user agent after cy.go Test Replay Output

The first 5 flaky specs are shown, see all 16 specs in Cypress Cloud.

Review all test suite changes for PR #27888 ↗︎

@cacieprins cacieprins merged commit 654e501 into develop Sep 28, 2023
5 checks passed
@cacieprins cacieprins deleted the cacie/chore/chrome-v3-ext branch September 28, 2023 16:05
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2023

Released in 13.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants