fix: statusCode allow 999 #27853
Merged
fix: statusCode allow 999 #27853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AtofStryker
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Hi @riwu. Changes look good, but would you be able to update your branch by syncing the fork? It's almost a year out of date. This way CI can run correctly.
riwu
force-pushed
the
patch-1
branch
3 times, most recently
from
ee8390d to
97ece9a
Compare
https://lodash.com/docs/#inRange `end` is exclusive, so it needs to be set to 1000 to allow status code 999 to be included (as per documented).
astone123
approved these changes
Sep 21, 2023
|
build failures are unrelated to these changes. merging. |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lodash.com/docs/#inRange
endis exclusive, so it needs to be set to 1000 to allow status code 999 to be included (as per documented).Closes #27567