Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: the minimum webpack version is 5 for @cypress/webpack-batteries-included-preprocessor #27469

Merged

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Aug 5, 2023

NEEDS TO BE REBASE MERGED IN AS A SINGLE COMMIT

Target release Monday 8/14/23

  • Closes N/A

Additional details

Publishes a major version of @cypress/webpack-batteries-included-preprocessor to bump the minimum webpack version from v4 to v5

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker mentioned this pull request Aug 5, 2023
3 tasks
@AtofStryker AtofStryker changed the title BREAKING_CHANGE: the minimum webpack version is 5 breaking: the minimum webpack version is 5 Aug 5, 2023
@AtofStryker AtofStryker changed the title breaking: the minimum webpack version is 5 BREAKING_CHANGE: the minimum webpack version is 5 Aug 5, 2023
@AtofStryker AtofStryker marked this pull request as ready for review August 5, 2023 03:13
@AtofStryker AtofStryker force-pushed the BREAKING_CHANGE/webpack-batteries-included-preprocessor branch from d7f67b5 to 97bbef4 Compare August 5, 2023 03:16
@cypress
Copy link

cypress bot commented Aug 5, 2023

36 flaky tests on run #49851 ↗︎

0 27949 1353 0 Flakiness 36

Details:

breaking: support webpack v5
Project: cypress Commit: e1a3a5c53f
Status: Passed Duration: 20:55 💡
Started: Aug 14, 2023 3:19 AM Ended: Aug 14, 2023 3:40 AM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
user agent override > persists modified user agent after cy.go Output Video
Flakiness  e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin navigation > .go() Output Video
Flakiness  e2e/origin/dependencies.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin dependencies > works Output Video
Flakiness  e2e/origin/commands/aliasing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin aliasing > .as() > supports dom elements inside origin Output Video

The first 5 flaky specs are shown, see all 23 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@AtofStryker AtofStryker force-pushed the chore/update_to_webpack5_minimum_lift branch from 6f196e1 to 4934d73 Compare August 7, 2023 00:22
@AtofStryker AtofStryker force-pushed the BREAKING_CHANGE/webpack-batteries-included-preprocessor branch from 97bbef4 to 2d5acd3 Compare August 7, 2023 00:24
@AtofStryker AtofStryker force-pushed the BREAKING_CHANGE/webpack-batteries-included-preprocessor branch 14 times, most recently from 12b2e05 to c341485 Compare August 7, 2023 15:59
@AtofStryker AtofStryker changed the title BREAKING_CHANGE: the minimum webpack version is 5 breaking: the minimum webpack version is 5 Aug 7, 2023
@AtofStryker AtofStryker force-pushed the BREAKING_CHANGE/webpack-batteries-included-preprocessor branch from c341485 to 941a3ef Compare August 7, 2023 16:04
@AtofStryker AtofStryker changed the title breaking: the minimum webpack version is 5 breaking: the minimum webpack version is 5 for @cypress/webpack-batteries-included-preprocessor Aug 7, 2023
@AtofStryker
Copy link
Contributor Author

verified locally with semantic release that this would bump the version correctly via DEBUG=semantic-release:commit-analyzer npx lerna exec --scope @cypress/webpack-batteries-included-preprocessor -- npx --no-install semantic-release --dry-run. To get the commit message correct, we will need to rebase merge this commit into develop once #27438 merges in

@AtofStryker AtofStryker force-pushed the chore/update_to_webpack5_minimum_lift branch from a51b816 to 721d6a5 Compare August 9, 2023 02:08
Base automatically changed from chore/update_to_webpack5_minimum_lift to develop August 9, 2023 15:59
@AtofStryker AtofStryker marked this pull request as draft August 9, 2023 16:04
@AtofStryker AtofStryker force-pushed the BREAKING_CHANGE/webpack-batteries-included-preprocessor branch from 941a3ef to 14f35ec Compare August 9, 2023 16:19
@AtofStryker AtofStryker marked this pull request as ready for review August 9, 2023 16:21
@lmiller1990 lmiller1990 self-requested a review August 9, 2023 21:33
BREAKING CHANGE: Since cypress now bundles with webpack v5, the minimum webpack version is now version 5 as this iswhat cypress will support in the monorepo moving forward. If you wish to use webpack 4, please use v2 of this package.
@AtofStryker AtofStryker force-pushed the BREAKING_CHANGE/webpack-batteries-included-preprocessor branch from 14f35ec to e1a3a5c Compare August 14, 2023 03:10
@nagash77 nagash77 merged commit 00fb578 into develop Aug 14, 2023
@nagash77 nagash77 deleted the BREAKING_CHANGE/webpack-batteries-included-preprocessor branch August 14, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants