chore: update to webpack v5 #27438
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /** | ||
| * as of Webpack 5, dependencies that are polyfilled through the Provide plugin must be defined inside the CLI | ||
| * in order to guarantee there is a version of the dependency accessible by the cypress CLI, either in the cypress directory | ||
| * or the root of their project. Currently, these two dependencies are 'buffer' and 'process' | ||
| */ | ||
| describe('dependencies', () => { | ||
|
There was a problem hiding this comment. I have some questions about this. If webpack 4 polyfilled all core Node.js libs out of the box, does that mean you could (and can)
I haven't tried this yet, but worth considering. I know we don't do this in our code base, but I'm sure some code bases rely on those polyfills (especially I wonder if we need to polyfill ALL the core modules to maintain backwards compatibility. There was a problem hiding this comment. I think it depends. |
||
| it('process dependency exists in package.json and is available', () => { | ||
| const { dependencies } = require('../../../package.json') | ||
|
|
||
| expect(dependencies.process).to.be.ok | ||
|
|
||
| const process = require('process') | ||
|
|
||
| expect(typeof process).to.equal('object') | ||
| }) | ||
|
|
||
| it('buffer dependency exists in package.json and is available', () => { | ||
| const { dependencies } = require('../../../package.json') | ||
|
|
||
| expect(dependencies.buffer).to.be.ok | ||
|
|
||
| const buffer = require('buffer') | ||
|
There was a problem hiding this comment. Should we assert that require('node:buffer') !== require('buffer')That would verify the There was a problem hiding this comment. that might be a good idea, considering we really want to just make sure the |
||
|
|
||
| expect(typeof buffer).to.equal('object') | ||
| }) | ||
| }) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| const path = require('path') | ||
| const webpack = require('webpack') | ||
| const webpackPreprocessor = require('@cypress/webpack-preprocessor') | ||
|
|
||
| const hasTsLoader = (rules) => { | ||
|
|
@@ -131,23 +132,51 @@ const getDefaultWebpackOptions = () => { | |
| loader: require.resolve('coffee-loader'), | ||
| }], | ||
| }, | ||
| plugins: [ | ||
| new webpack.ProvidePlugin({ | ||
| Buffer: ['buffer', 'Buffer'], | ||
| process: 'process/browser', | ||
| }), | ||
| ], | ||
| resolve: { | ||
| extensions: ['.js', '.json', '.jsx', '.mjs', '.coffee'], | ||
| fallback: { | ||
lmiller1990 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| assert: require.resolve('assert/'), | ||
| buffer: require.resolve('buffer/'), | ||
| child_process: false, | ||
| cluster: false, | ||
| console: false, | ||
| constants: require.resolve('constants-browserify'), | ||
| crypto: require.resolve('crypto-browserify'), | ||
| dgram: false, | ||
| dns: false, | ||
| domain: require.resolve('domain-browser'), | ||
| events: require.resolve('events/'), | ||
| fs: false, | ||
| http: require.resolve('stream-http'), | ||
| https: require.resolve('https-browserify'), | ||
| http2: false, | ||
| inspector: false, | ||
| module: false, | ||
| net: false, | ||
| os: require.resolve('os-browserify/browser'), | ||
| path: require.resolve('path-browserify'), | ||
| perf_hooks: false, | ||
| punycode: require.resolve('punycode/'), | ||
| process: require.resolve('process/browser'), | ||
| querystring: require.resolve('querystring-es3'), | ||
| readline: false, | ||
| repl: false, | ||
| stream: require.resolve('stream-browserify'), | ||
| string_decoder: require.resolve('string_decoder/'), | ||
| sys: require.resolve('util/'), | ||
| timers: require.resolve('timers-browserify'), | ||
|
There was a problem hiding this comment. Oh, maybe we do polyfill them all. My previous comment may be irrelevant. Big breaking change here - who knows if these implementations match whatever webpack 4 was doing. Tracking down the right polyfill here must have been complex. There was a problem hiding this comment.
This for sure breaks the
this gist for sure helped to figure out what was going on |
||
| tls: false, | ||
| tty: require.resolve('tty-browserify'), | ||
| url: require.resolve('url/'), | ||
| util: require.resolve('util/'), | ||
| vm: require.resolve('vm-browserify'), | ||
| zlib: require.resolve('browserify-zlib'), | ||
| }, | ||
| plugins: [], | ||
| }, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would they also need to install webpack@4 to keep things working the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in this case because
v2ofwebpack-batteries-included-preprocesorships with 4. its not backwards compatible unlike the regularwebpack-preprocessor