Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(system-tests): add a regression test for #23552 #23695

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

lmiller1990
Copy link
Contributor

User facing changelog

N/A

Additional details

Fixed passively by #23637. We don't have any tests around module: NodeNext in tsconfig.json so I added one.

Steps to test

N/A, just ensure CI is green. That is the test!

You could check out git checkout b5ba6d7b87deaa8b5f275b20e38127b740490bfd which is the commit before #23637 which fixed this, run yarn install and run the system test and watch it regress, if you really want.

How has the user experience changed?

Works with module: "NodeNext".

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 7, 2022

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 marked this pull request as ready for review September 7, 2022 04:07
@lmiller1990 lmiller1990 changed the title test: add regression test for #23552 chore: add regression test for #23552 Sep 7, 2022
@cypress
Copy link

cypress bot commented Sep 7, 2022



Test summary

39674 0 3345 0Flakiness 1


Run details

Project cypress
Status Passed
Commit cc74340
Started Sep 8, 2022 3:17 AM
Ended Sep 8, 2022 3:32 AM
Duration 15:02 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/commands/connectors.cy.ts Flakiness
1 cy.origin connectors > .each()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 changed the title chore: add regression test for #23552 chore: add a regression test for #23552 Sep 7, 2022
@lmiller1990 lmiller1990 changed the title chore: add a regression test for #23552 chore(system-tests): add a regression test for #23552 Sep 8, 2022
@lmiller1990 lmiller1990 changed the title chore(system-tests): add a regression test for #23552 test(system-tests): add a regression test for #23552 Sep 8, 2022
@lmiller1990 lmiller1990 force-pushed the issues/23552-regression branch from 1ca0dda to cc74340 Compare September 8, 2022 03:11
@lmiller1990 lmiller1990 requested review from rachelruderman and removed request for flotwig and emilyrohrbough September 9, 2022 08:39
@lmiller1990 lmiller1990 merged commit a2170ac into develop Sep 12, 2022
@lmiller1990 lmiller1990 deleted the issues/23552-regression branch September 12, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cypress.config.ts does not work with ESM: "exports is not defined in ES module scope"
3 participants