Skip to content

Commit

Permalink
Remove electron version instructions for adding to step that no longe…
Browse files Browse the repository at this point in the history
…r exists
  • Loading branch information
jennifer-shehane committed Oct 2, 2024
1 parent c884f94 commit ebe7ba6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/electron/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ Upgrading `electron` involves more than just bumping this package's `package.jso
- The [NodeJS](https://nodejs.org/en) version is not the active LTS.
- [ ] **Update `workflows.yml`**
- [ ] Ensure it references the new `base-internal` and `browsers-internal` Docker images
- [ ] Ensure the new Electron version is used as a build target in the `Build better-sqlite3 for CentOS 7` step

- [ ] **Ensure that a matching Node.js version is enforced in the monorepo for local development and CI.** When Electron is upgraded, oftentimes, the bundled Node.js version that comes with Electron is updated as well. Because all unit and integration tests run in normal Node.js (not Electron's Node.js), it's important for this Node.js version to be synced with the monorepo. There are a few places where this needs to be done:
- [ ] [`/.node-version`](../../.node-version) - used by `nvm` and other Node version managers
Expand Down

3 comments on commit ebe7ba6

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on ebe7ba6 Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/linux-x64/release/14.0.0-ebe7ba688802ca2f091783b72070ebaf39940482/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on ebe7ba6 Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/darwin-arm64/release/14.0.0-ebe7ba688802ca2f091783b72070ebaf39940482/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on ebe7ba6 Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/darwin-x64/release/14.0.0-ebe7ba688802ca2f091783b72070ebaf39940482/cypress.tgz

Please sign in to comment.