Skip to content

Commit

Permalink
breaking: remove the cypress/angular-signals test harness. The change…
Browse files Browse the repository at this point in the history
…s incorporated in @cypress/angular-signals are now merged upstream into @cypress/angular and the package is no longer needed [run ci]
  • Loading branch information
AtofStryker committed Nov 6, 2024
1 parent 3141d12 commit d434834
Show file tree
Hide file tree
Showing 27 changed files with 180 additions and 753 deletions.
2 changes: 1 addition & 1 deletion .circleci/cache-version.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Bump this version to force CI to re-create the cache from scratch.

11-1-24
11-06-24-angular-signals-removal
17 changes: 0 additions & 17 deletions .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2163,15 +2163,6 @@ jobs:
command: yarn lerna run build --scope=@cypress/angular
- store-npm-logs

npm-angular-signals:
<<: *defaults
steps:
- restore_cached_workspace
- run:
name: Build
command: yarn lerna run build --scope=@cypress/angular-signals
- store-npm-logs

npm-puppeteer-unit-tests:
<<: *defaults
steps:
Expand Down Expand Up @@ -2943,9 +2934,6 @@ linux-x64-workflow: &linux-x64-workflow
- npm-angular:
requires:
- build
- npm-angular-signals:
requires:
- build
- npm-mount-utils:
requires:
- build
Expand All @@ -2964,7 +2952,6 @@ linux-x64-workflow: &linux-x64-workflow
requires:
- check-ts
- npm-angular
- npm-angular-signals
- npm-eslint-plugin-dev
- npm-puppeteer-unit-tests
- npm-puppeteer-cypress-tests
Expand Down Expand Up @@ -3302,9 +3289,6 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow
- npm-angular:
requires:
- build
- npm-angular-signals:
requires:
- build
- npm-mount-utils:
requires:
- build
Expand All @@ -3322,7 +3306,6 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow
requires:
- check-ts
- npm-angular
- npm-angular-signals
- npm-eslint-plugin-dev
- npm-puppeteer-unit-tests
- npm-puppeteer-cypress-tests
Expand Down
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

- [Cypress App](https://on.cypress.io/changelog)
- [`@cypress/angular`](https://github.com/cypress-io/cypress/blob/develop/npm/angular/CHANGELOG.md)
- [`@cypress/angular-signals`](https://github.com/cypress-io/cypress/blob/develop/npm/angular-signals/CHANGELOG.md)
- [`@cypress/eslint-plugin-dev`](https://github.com/cypress-io/cypress/blob/develop/npm/eslint-plugin-dev/CHANGELOG.md)
- [`@cypress/mount-utils`](https://github.com/cypress-io/cypress/blob/develop/npm/mount-utils/CHANGELOG.md)
- [`@cypress/react`](https://github.com/cypress-io/cypress/blob/develop/npm/react/CHANGELOG.md)
Expand Down
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ Here is a list of the npm packages in this repository:
| Folder Name | Package Name | Purpose |
| :----------------------------------------------------- | :--------------------------------- | :--------------------------------------------------------------------------- |
| [angular](./npm/angular) | `@cypress/angular` | Cypress component testing for Angular. |
| [angular signals](./npm/angular-signals) | `@cypress/angular-signals` | Cypress component testing for Angular 17/18 including support for signals. |
| [eslint-plugin-dev](./npm/eslint-plugin-dev) | `@cypress/eslint-plugin-dev` | Eslint plugin for internal development. |
| [grep](./npm/grep) | `@cypress/grep` | Filter tests using substring |
| [mount-utils](./npm/mount-utils) | `@cypress/mount-utils` | Common functionality for Vue/React/Angular adapters. |
Expand Down
1 change: 0 additions & 1 deletion cli/.eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ package.json

# these are all copied from dist'd builds from the individual libs
/angular
/angular-signals
/react
/react18
/vue
Expand Down
1 change: 0 additions & 1 deletion cli/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,3 @@ react*
mount-utils
angular
svelte
angular-signals
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ _Released 12/3/2024 (PENDING)_
- Cypress Component Testing no longer supports `Vue` version 2. Addresses [#30295](https://github.com/cypress-io/cypress/issues/30295).
- Cypress Component Testing no longer supports `Next.js` versions 10, 11, 12, and 13. Addresses [#29583](https://github.com/cypress-io/cypress/issues/29583).
- Cypress Component Testing no longer supports `Angular` versions 13, 14, 15, and 16. The minimum supported version is now `17.2.0` in order to fully support Angular [signals](https://angular.dev/guide/signals). Addresses [#29582](https://github.com/cypress-io/cypress/issues/29582). Addressed in [#30539](https://github.com/cypress-io/cypress/pull/30539).
- The `cypress/angular-signals` test harness is no longer included in the Cypress binary. Instead, signals support is now shipped with `cypress/angular`! This requires `rxjs` to be installed as a `peerDependency`. Addresses [#29606](https://github.com/cypress-io/cypress/issues/29606).

**Deprecations:**

Expand Down
9 changes: 1 addition & 8 deletions cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
"@babel/cli": "7.24.8",
"@babel/preset-env": "7.25.3",
"@cypress/angular": "0.0.0-development",
"@cypress/angular-signals": "0.0.0-development",
"@cypress/grep": "0.0.0-development",
"@cypress/mount-utils": "0.0.0-development",
"@cypress/react": "0.0.0-development",
Expand Down Expand Up @@ -117,8 +116,7 @@
"react",
"react18",
"angular",
"svelte",
"angular-signals"
"svelte"
],
"bin": {
"cypress": "bin/cypress"
Expand Down Expand Up @@ -165,11 +163,6 @@
"types": "./svelte/dist/index.d.ts",
"import": "./svelte/dist/cypress-svelte.esm-bundler.js",
"require": "./svelte/dist/cypress-svelte.cjs.js"
},
"./angular-signals": {
"types": "./angular-signals/dist/index.d.ts",
"import": "./angular-signals/dist/index.js",
"require": "./angular-signals/dist/index.js"
}
},
"workspaces": {
Expand Down
1 change: 0 additions & 1 deletion cli/scripts/post-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const npmModulesToCopy = [
'react18',
'vue',
'angular',
'angular-signals',
'svelte',
]

Expand Down
5 changes: 0 additions & 5 deletions npm/angular-signals/.eslintignore

This file was deleted.

8 changes: 0 additions & 8 deletions npm/angular-signals/.eslintrc

This file was deleted.

3 changes: 0 additions & 3 deletions npm/angular-signals/.npmignore

This file was deleted.

3 changes: 0 additions & 3 deletions npm/angular-signals/.releaserc.js

This file was deleted.

6 changes: 0 additions & 6 deletions npm/angular-signals/CHANGELOG.md

This file was deleted.

11 changes: 0 additions & 11 deletions npm/angular-signals/README.md

This file was deleted.

74 changes: 0 additions & 74 deletions npm/angular-signals/package.json

This file was deleted.

14 changes: 0 additions & 14 deletions npm/angular-signals/rollup.config.mjs

This file was deleted.

1 change: 0 additions & 1 deletion npm/angular-signals/src/index.ts

This file was deleted.

Loading

0 comments on commit d434834

Please sign in to comment.