updating tests

cypress-io · Dec 11, 2024 · c0a2584 · c0a2584
1 parent faa2984
commit c0a2584
Show file tree

Hide file tree

Showing 15 changed files with 227 additions and 174 deletions.
diff --git a/packages/errors/__snapshot-html__/BROWSER_NOT_FOUND_BY_NAME - canary.html b/packages/errors/__snapshot-html__/BROWSER_NOT_FOUND_BY_NAME - canary.html
diff --git a/packages/errors/__snapshot-html__/BROWSER_NOT_FOUND_BY_NAME.html b/packages/errors/__snapshot-html__/BROWSER_NOT_FOUND_BY_NAME.html
diff --git a/packages/errors/src/errors.ts b/packages/errors/src/errors.ts
@@ -120,7 +120,7 @@ export const AllCypressErrors = {
         Browser: ${fmt.highlight(browser)} was not found on your system or is not supported by Cypress.
 
         Cypress supports the following browsers:
-        ${fmt.listItems(['electron', 'chrome', 'chromium', 'chrome:canary', 'edge', 'firefox'])}
+        ${fmt.listItems(['electron', 'chrome', 'chromium', 'chrome-for-testing', 'edge', 'firefox'])}
 
         You can also use a custom browser: https://on.cypress.io/customize-browsers
 

diff --git a/packages/launcher/__snapshots__/browsers_spec.ts.js b/packages/launcher/__snapshots__/browsers_spec.ts.js
@@ -12,18 +12,6 @@ exports['browsers returns the expected list of browsers 1'] = [
     ],
     'minSupportedVersion': 64,
   },
-  {
-    'name': 'chromium',
-    'family': 'chromium',
-    'channel': 'stable',
-    'displayName': 'Chromium',
-    'versionRegex': {},
-    'binary': [
-      'chromium-browser',
-      'chromium',
-    ],
-    'minSupportedVersion': 64,
-  },
   {
     'name': 'chrome',
     'family': 'chromium',
@@ -37,11 +25,32 @@ exports['browsers returns the expected list of browsers 1'] = [
     'name': 'chrome',
     'family': 'chromium',
     'channel': 'canary',
-    'displayName': 'Canary',
+    'displayName': 'Chrome Canary',
     'versionRegex': {},
     'binary': 'google-chrome-canary',
     'minSupportedVersion': 64,
   },
+  {
+    'name': 'chrome-for-testing',
+    'family': 'chromium',
+    'channel': 'stable',
+    'displayName': 'Chrome Test',
+    'versionRegex': {},
+    'binary': 'chrome',
+    'minSupportedVersion': 64,
+  },
+  {
+    'name': 'chromium',
+    'family': 'chromium',
+    'channel': 'stable',
+    'displayName': 'Chromium',
+    'versionRegex': {},
+    'binary': [
+      'chromium-browser',
+      'chromium',
+    ],
+    'minSupportedVersion': 64,
+  },
   {
     'name': 'firefox',
     'family': 'firefox',

diff --git a/packages/launcher/__snapshots__/darwin_spec.ts.js b/packages/launcher/__snapshots__/darwin_spec.ts.js
@@ -16,30 +16,10 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Google Chrome.app',
       'executable': 'Contents/MacOS/Google Chrome',
-      'appId': 'com.google.Chrome',
+      'bundleId': 'com.google.Chrome',
       'versionProperty': 'KSVersion',
     },
   },
-  {
-    'name': 'chromium',
-    'family': 'chromium',
-    'channel': 'stable',
-    'displayName': 'Chromium',
-    'versionRegex': {},
-    'binary': [
-      'chromium-browser',
-      'chromium',
-    ],
-    'minSupportedVersion': 64,
-    'path': '/Applications/Chromium.app/Contents/MacOS/Chromium',
-    'version': 'someVersion',
-    'findAppParams': {
-      'appName': 'Chromium.app',
-      'executable': 'Contents/MacOS/Chromium',
-      'appId': 'org.chromium.Chromium',
-      'versionProperty': 'CFBundleShortVersionString',
-    },
-  },
   {
     'name': 'chrome',
     'family': 'chromium',
@@ -53,15 +33,15 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Google Chrome Beta.app',
       'executable': 'Contents/MacOS/Google Chrome Beta',
-      'appId': 'com.google.Chrome.beta',
+      'bundleId': 'com.google.Chrome.beta',
       'versionProperty': 'KSVersion',
     },
   },
   {
     'name': 'chrome',
     'family': 'chromium',
     'channel': 'canary',
-    'displayName': 'Canary',
+    'displayName': 'Chrome Canary',
     'versionRegex': {},
     'binary': 'google-chrome-canary',
     'minSupportedVersion': 64,
@@ -70,10 +50,47 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Google Chrome Canary.app',
       'executable': 'Contents/MacOS/Google Chrome Canary',
-      'appId': 'com.google.Chrome.canary',
+      'bundleId': 'com.google.Chrome.canary',
       'versionProperty': 'KSVersion',
     },
   },
+  {
+    'name': 'chrome-for-testing',
+    'family': 'chromium',
+    'channel': 'stable',
+    'displayName': 'Chrome Test',
+    'versionRegex': {},
+    'binary': 'chrome',
+    'minSupportedVersion': 64,
+    'path': '/Applications/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing',
+    'version': 'someVersion',
+    'findAppParams': {
+      'appName': 'Google Chrome for Testing.app',
+      'executable': 'Contents/MacOS/Google Chrome for Testing',
+      'bundleId': 'com.google.chrome.for.testing',
+      'versionProperty': 'CFBundleShortVersionString',
+    },
+  },
+  {
+    'name': 'chromium',
+    'family': 'chromium',
+    'channel': 'stable',
+    'displayName': 'Chromium',
+    'versionRegex': {},
+    'binary': [
+      'chromium-browser',
+      'chromium',
+    ],
+    'minSupportedVersion': 64,
+    'path': '/Applications/Chromium.app/Contents/MacOS/Chromium',
+    'version': 'someVersion',
+    'findAppParams': {
+      'appName': 'Chromium.app',
+      'executable': 'Contents/MacOS/Chromium',
+      'bundleId': 'org.chromium.Chromium',
+      'versionProperty': 'CFBundleShortVersionString',
+    },
+  },
   {
     'name': 'firefox',
     'family': 'firefox',
@@ -87,7 +104,7 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Firefox.app',
       'executable': 'Contents/MacOS/firefox',
-      'appId': 'org.mozilla.firefox',
+      'bundleId': 'org.mozilla.firefox',
       'versionProperty': 'CFBundleShortVersionString',
     },
   },
@@ -107,7 +124,7 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Firefox Developer Edition.app',
       'executable': 'Contents/MacOS/firefox',
-      'appId': 'org.mozilla.firefoxdeveloperedition',
+      'bundleId': 'org.mozilla.firefoxdeveloperedition',
       'versionProperty': 'CFBundleShortVersionString',
     },
   },
@@ -127,7 +144,7 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Firefox Nightly.app',
       'executable': 'Contents/MacOS/firefox',
-      'appId': 'org.mozilla.nightly',
+      'bundleId': 'org.mozilla.nightly',
       'versionProperty': 'CFBundleShortVersionString',
     },
   },
@@ -147,7 +164,7 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Microsoft Edge.app',
       'executable': 'Contents/MacOS/Microsoft Edge',
-      'appId': 'com.microsoft.Edge',
+      'bundleId': 'com.microsoft.Edge',
       'versionProperty': 'CFBundleShortVersionString',
     },
   },
@@ -167,7 +184,7 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Microsoft Edge Canary.app',
       'executable': 'Contents/MacOS/Microsoft Edge Canary',
-      'appId': 'com.microsoft.Edge.Canary',
+      'bundleId': 'com.microsoft.Edge.Canary',
       'versionProperty': 'CFBundleShortVersionString',
     },
   },
@@ -187,7 +204,7 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Microsoft Edge Beta.app',
       'executable': 'Contents/MacOS/Microsoft Edge Beta',
-      'appId': 'com.microsoft.Edge.Beta',
+      'bundleId': 'com.microsoft.Edge.Beta',
       'versionProperty': 'CFBundleShortVersionString',
     },
   },
@@ -207,7 +224,7 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'findAppParams': {
       'appName': 'Microsoft Edge Dev.app',
       'executable': 'Contents/MacOS/Microsoft Edge Dev',
-      'appId': 'com.microsoft.Edge.Dev',
+      'bundleId': 'com.microsoft.Edge.Dev',
       'versionProperty': 'CFBundleShortVersionString',
     },
   },