Skip to content

Commit

Permalink
chore: bring contributor PR approval check earlier
Browse files Browse the repository at this point in the history
  • Loading branch information
jennifer-shehane committed Nov 1, 2024
1 parent b8a5280 commit 789b91b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 39 deletions.
7 changes: 6 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,9 @@ workflows:
# the setup-workflow workflow is always triggered.
setup-workflow:
jobs:
- verify-ci-should-run
# This job will allow for a Cypress member to approve and run the code changes from contributors after being reviewed.
- contributor-pr:
type: approval
- verify-ci-should-run:
requires:
- contributor-pr
38 changes: 0 additions & 38 deletions .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3111,12 +3111,6 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow
- build:
requires:
- node_modules_install
# In subsequent jobs, we use some contexts that are restricted to members of the Cypress organization.
# This job will allow for a Cypress member to approve and run the rest of the restricted jobs in the pipeline after the contributor code has been reviewed.
- contributor-pr:
type: approval
requires:
- build
# verify-accessibility-results is required for status checks, however, it will be skipped for contributors so it
# can run in any order
- verify-accessibility-results
Expand Down Expand Up @@ -3147,15 +3141,11 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow
# unit, integration and e2e tests
- cli-visual-tests:
context: test-runner:percy
requires:
- contributor-pr
- unit-tests:
requires:
- build
- verify-release-readiness:
context: test-runner:npm-release
requires:
- contributor-pr
- server-unit-tests:
requires:
- build
Expand All @@ -3167,8 +3157,6 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow
- build
- system-tests-node-modules-install:
context: test-runner:performance-tracking
requires:
- contributor-pr
- system-tests-chrome:
context: test-runner:performance-tracking
requires:
Expand All @@ -3192,47 +3180,29 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow
- system-tests-node-modules-install
- driver-integration-tests-chrome:
context: test-runner:cypress-record-key
requires:
- contributor-pr
- driver-integration-tests-chrome-beta:
context: test-runner:cypress-record-key
requires:
- contributor-pr
- driver-integration-tests-firefox:
context: test-runner:cypress-record-key
requires:
- contributor-pr
- driver-integration-tests-electron:
context: test-runner:cypress-record-key
requires:
- contributor-pr
- driver-integration-tests-webkit:
context: test-runner:cypress-record-key
requires:
- contributor-pr
- driver-integration-memory-tests:
requires:
- build
- run-frontend-shared-component-tests-chrome:
context: [test-runner:cypress-record-key, test-runner:launchpad-tests, test-runner:percy]
percy: true
requires:
- contributor-pr
- run-launchpad-integration-tests-chrome:
context: [test-runner:cypress-record-key, test-runner:launchpad-tests, test-runner:percy]
percy: true
requires:
- contributor-pr
- run-launchpad-component-tests-chrome:
context: [test-runner:cypress-record-key, test-runner:launchpad-tests, test-runner:percy]
percy: true
requires:
- contributor-pr
- run-app-integration-tests-chrome:
context: [test-runner:cypress-record-key, test-runner:launchpad-tests, test-runner:percy]
percy: true
requires:
- contributor-pr
- run-webpack-dev-server-integration-tests:
context: [test-runner:cypress-record-key, test-runner:percy]
requires:
Expand All @@ -3244,17 +3214,11 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow
- run-app-component-tests-chrome:
context: [test-runner:cypress-record-key, test-runner:launchpad-tests, test-runner:percy]
percy: true
requires:
- contributor-pr
- run-reporter-component-tests-chrome:
context: [test-runner:cypress-record-key, test-runner:percy]
percy: true
requires:
- contributor-pr
- reporter-integration-tests:
context: [test-runner:cypress-record-key, test-runner:percy]
requires:
- contributor-pr
- npm-webpack-dev-server:
requires:
- system-tests-node-modules-install
Expand Down Expand Up @@ -3354,8 +3318,6 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow

- create-and-trigger-packaging-artifacts:
context: [test-runner:upload, test-runner:build-binary, publish-binary]
requires:
- contributor-pr
- get-published-artifacts:
context: [publish-binary, test-runner:commit-status-checks]
requires:
Expand Down

0 comments on commit 789b91b

Please sign in to comment.