Skip to content

Commit

Permalink
fix: turn off svgo from @svgr/webpack to preserve our scss class name…
Browse files Browse the repository at this point in the history
…s within the svg. see https://react-svgr.com/docs/options/#svgo [run ci]
  • Loading branch information
AtofStryker committed Aug 10, 2023
1 parent da958e4 commit 661f07c
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion packages/web-config/webpack.config.base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,15 @@ export const getCommonConfig = () => {
{
test: /\.svg$/i,
issuer: /\.[jt]sx?$/,
use: ['@svgr/webpack'],
use: [{
loader: '@svgr/webpack',
options: {
// we leverage classes in our svgs that correspond to scss classes.
// svgo prefixes these classes be default, which we don't want, so we must disable it
// @see https://react-svgr.com/docs/options/#svgo
svgo: false,
},
}],
},
{
test: /\.wasm$/,
Expand Down

5 comments on commit 661f07c

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 661f07c Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.4/darwin-arm64/chore/bump_loaders_and_optimize_webpack-661f07c3eca6e9da577659bf7d602c6b067b9793/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 661f07c Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.4/linux-x64/chore/bump_loaders_and_optimize_webpack-661f07c3eca6e9da577659bf7d602c6b067b9793/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 661f07c Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.4/linux-arm64/chore/bump_loaders_and_optimize_webpack-661f07c3eca6e9da577659bf7d602c6b067b9793/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 661f07c Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.4/darwin-x64/chore/bump_loaders_and_optimize_webpack-661f07c3eca6e9da577659bf7d602c6b067b9793/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 661f07c Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.4/win32-x64/chore/bump_loaders_and_optimize_webpack-661f07c3eca6e9da577659bf7d602c6b067b9793/cypress.tgz

Please sign in to comment.