Skip to content

Commit

Permalink
remove firefox 130 changes
Browse files Browse the repository at this point in the history
  • Loading branch information
mschile committed Dec 6, 2024
1 parent 6dd40fa commit 50a4997
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion scripts/binary/trigger-publish-binary-pipeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const { getNextVersionForBinary } = require('../get-next-version')
const { nextVersion } = await getNextVersionForBinary()

const body = JSON.stringify({
branch: 'ryanm/chore/electron-33-upgrade',
branch: 'release/14.0.0',
parameters: {
temp_dir: os.tmpdir(),
sha: process.env.CIRCLE_SHA1,
Expand Down
7 changes: 1 addition & 6 deletions system-tests/lib/normalizeStdout.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ export const normalizeStdout = function (str: string, options: any = {}) {
str = str.split('\n').filter((line) => !line.includes(wdsFailedMsg)).join('\n')
}

// in Firefox 130, height dimensions are off by 1 pixel (721px local and 719px CI), so we need to fix the offset to match common snapshots
// in Firefox 133, height dimensions are off by 43/44 pixels (677px local and 676px CI), so we need to fix the offset to match common snapshots
if (options.browser === 'firefox') {
const dimensionRegex = new RegExp(/(\((?<width>\d+)x(?<height>\d+)\))/g)
Expand All @@ -193,11 +192,7 @@ export const normalizeStdout = function (str: string, options: any = {}) {
let expectedHeight = height
const expectedWidth = matches?.groups?.width

if (height === 719) { // only happens on default height for whatever reason in firefox 130...
expectedHeight = height + 1
} else if (height === 721) { // only happens on default height for whatever reason in firefox 130...
expectedHeight = height - 1
} else if (height === 676) { // only happens on default height for whatever reason in firefox 133...
if (height === 676) { // only happens on default height for whatever reason in firefox 133...
expectedHeight = height + 44
} else if (height === 677) { // only happens on default height for whatever reason in firefox 133...
expectedHeight = height + 43
Expand Down

5 comments on commit 50a4997

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 50a4997 Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/linux-x64/ryanm/chore/electron-33-upgrade-50a499743322ac9f6768f8c36742d3a4cb79a357/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 50a4997 Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/linux-arm64/ryanm/chore/electron-33-upgrade-50a499743322ac9f6768f8c36742d3a4cb79a357/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 50a4997 Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/win32-x64/ryanm/chore/electron-33-upgrade-50a499743322ac9f6768f8c36742d3a4cb79a357/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 50a4997 Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/darwin-arm64/ryanm/chore/electron-33-upgrade-50a499743322ac9f6768f8c36742d3a4cb79a357/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 50a4997 Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/14.0.0/darwin-x64/ryanm/chore/electron-33-upgrade-50a499743322ac9f6768f8c36742d3a4cb79a357/cypress.tgz

Please sign in to comment.