Skip to content

Commit

Permalink
chore: remove deprecated system test execOptions (#30478)
Browse files Browse the repository at this point in the history
* chore: remove deprecated system test execOptions

* empty commit
  • Loading branch information
jennifer-shehane authored Nov 1, 2024
1 parent 1760b0e commit 41623ed
Showing 1 changed file with 0 additions and 31 deletions.
31 changes: 0 additions & 31 deletions system-tests/lib/system-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,16 +79,6 @@ type ExecOptions = {
* If set, test using the built Cypress CLI and binary. Expects a built CLI in `/cli/build` and packed binary in `/cypress.zip`.
*/
withBinary?: boolean
/**
* Deprecated. Use `--cypress-inspect-brk` from command line instead.
* @deprecated
*/
inspectBrk?: null
/**
* Deprecated. Use `--no-exit` from command line instead.
* @deprecated
*/
exit?: null
/**
* Don't exit when tests are finished. You can also pass `--no-exit` via the command line.
*/
Expand Down Expand Up @@ -629,14 +619,6 @@ const systemTests = {
},

options (ctx, options: ExecOptions) {
if (options.inspectBrk != null) {
throw new Error(`
passing { inspectBrk: true } to system test options is no longer supported
Please pass the --cypress-inspect-brk flag to the test command instead
e.g. "yarn test async_timeouts_spec.js --cypress-inspect-brk"
`)
}

_.defaults(options, {
browser: process.env.SNAPSHOT_BROWSER || 'electron',
headed: process.env.HEADED || false,
Expand All @@ -648,19 +630,10 @@ const systemTests = {
sanitizeScreenshotDimensions: false,
normalizeStdoutAvailableBrowsers: true,
noExit: process.env.NO_EXIT,
inspectBrk: process.env.CYPRESS_INSPECT_BRK,
})

const projectPath = Fixtures.projectPath(options.project)

if (options.exit != null) {
throw new Error(`
passing { exit: false } to system test options is no longer supported
Please pass the --no-exit flag to the test command instead
e.g. "yarn test async_timeouts_spec.js --no-exit"
`)
}

if (options.noExit && options.timeout < 3000000) {
options.timeout = 3000000
}
Expand Down Expand Up @@ -770,10 +743,6 @@ const systemTests = {
args.push('--no-exit')
}

if (options.inspectBrk) {
args.push('--inspect-brk')
}

if (options.tag) {
args.push(`--tag=${options.tag}`)
}
Expand Down

5 comments on commit 41623ed

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 41623ed Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.15.2/linux-arm64/develop-41623ed0e57c290d9a275cd41edbe0962e5630bd/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 41623ed Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.15.2/linux-x64/develop-41623ed0e57c290d9a275cd41edbe0962e5630bd/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 41623ed Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.15.2/darwin-arm64/develop-41623ed0e57c290d9a275cd41edbe0962e5630bd/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 41623ed Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.15.2/win32-x64/develop-41623ed0e57c290d9a275cd41edbe0962e5630bd/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 41623ed Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.15.2/darwin-x64/develop-41623ed0e57c290d9a275cd41edbe0962e5630bd/cypress.tgz

Please sign in to comment.