remove svelte 3 support

cypress-io · Nov 7, 2024 · 278f642 · 278f642
1 parent 3141d12
commit 278f642
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/cli/types/cypress.d.ts b/cli/types/cypress.d.ts
@@ -3393,7 +3393,7 @@ declare namespace Cypress {
     type: string
 
     /**
-     * Used as the flag for `getPreset` for meta framworks, such as finding the webpack config for CRA, Angular, etc.
+     * Used as the flag for `getPreset` for meta frameworks, such as finding the webpack config for CRA, Angular, etc.
      * It is also the name of the string added to `cypress.config`
      *
      * @example
@@ -3445,12 +3445,12 @@ declare namespace Cypress {
     dependencies: (bundler: 'webpack' | 'vite', projectPath: string) => Promise<DependencyToInstall[]>
 
     /**
-     * This is used interally by Cypress for the "Create From Component" feature.
+     * This is used internally by Cypress for the "Create From Component" feature.
      */
     codeGenFramework?: 'react' | 'vue' | 'svelte' | 'angular'
 
     /**
-     * This is used interally by Cypress for the "Create From Component" feature.
+     * This is used internally by Cypress for the "Create From Component" feature.
      * @example '*.{js,jsx,tsx}'
      */
     glob?: string

diff --git a/npm/svelte/package.json b/npm/svelte/package.json
@@ -12,12 +12,12 @@
   },
   "devDependencies": {
     "@cypress/mount-utils": "0.0.0-development",
-    "svelte": "^3.49.0",
+    "svelte": "^4.2.19",
     "typescript": "~5.4.5"
   },
   "peerDependencies": {
     "cypress": ">=10.6.0",
-    "svelte": ">=3.0.0"
+    "svelte": ">=4.0.0"
   },
   "files": [
     "dist/**/*"

diff --git a/packages/scaffold-config/src/dependencies.ts b/packages/scaffold-config/src/dependencies.ts
@@ -130,7 +130,7 @@ export const WIZARD_DEPENDENCY_SVELTE: Cypress.CypressComponentDependency = {
   package: 'svelte',
   installer: 'svelte',
   description: 'Cybernetically enhanced web apps',
-  minVersion: '^3.0.0 || ^4.0.0',
+  minVersion: '^4.0.0 || ^5.0.0',
 } as const
 
 export const WIZARD_DEPENDENCIES = [

diff --git a/packages/scaffold-config/test/unit/detect.spec.ts b/packages/scaffold-config/test/unit/detect.spec.ts
@@ -191,7 +191,7 @@ describe('detectFramework', () => {
       const projectPath = await scaffoldMigrationProject('svelte-vite-unconfigured')
 
       fakeDepsInNodeModules(projectPath, [
-        { dependency: 'svelte', version: '3.0.0' },
+        { dependency: 'svelte', version: '5.0.0' },
         { dependency: 'vite', version: v },
       ])
 
@@ -206,7 +206,7 @@ describe('detectFramework', () => {
     const projectPath = await scaffoldMigrationProject('svelte-webpack-unconfigured')
 
     fakeDepsInNodeModules(projectPath, [
-      { dependency: 'svelte', version: '3.0.0' },
+      { dependency: 'svelte', version: '5.0.0' },
       { dependency: 'webpack', version: '5.0.0' },
     ])
 

diff --git a/system-tests/projects/svelte-webpack-unconfigured/package.json b/system-tests/projects/svelte-webpack-unconfigured/package.json
@@ -9,7 +9,7 @@
     "cross-env": "^7.0.3",
     "css-loader": "^5.0.1",
     "mini-css-extract-plugin": "^2.9.1",
-    "svelte": "^3.31.2",
+    "svelte": "^5.1.11",
     "svelte-loader": "^3.0.0",
     "webpack": "^5.16.0",
     "webpack-cli": "^4.10.0",

diff --git a/system-tests/projects/svelte-webpack/package.json b/system-tests/projects/svelte-webpack/package.json
@@ -6,7 +6,7 @@
     "css-loader": "^6.7.1",
     "html-webpack-plugin": "^5.5.0",
     "mini-css-extract-plugin": "^2.9.1",
-    "svelte": "^3.44.0",
+    "svelte": "^5.1.11",
     "svelte-loader": "^3.1.3",
     "webpack": "^5.74.0",
     "webpack-dev-server": "^4.10.0"