breaking: remove Svelte 3 support (#30572)

cypress-io · Nov 9, 2024 · 249da65 · 249da65 · cypress-bot · Nov 9, 2024
1 parent 37b944f
commit 249da65
Show file tree

Hide file tree

Showing 12 changed files with 1,266 additions and 928 deletions.
diff --git a/cli/CHANGELOG.md b/cli/CHANGELOG.md
@@ -21,6 +21,7 @@ _Released 12/3/2024 (PENDING)_
 - Cypress Component Testing no longer supports `Vue` version 2. Addresses [#30295](https://github.com/cypress-io/cypress/issues/30295).
 - Cypress Component Testing no longer supports `Next.js` versions 10, 11, 12, and 13. Addresses [#29583](https://github.com/cypress-io/cypress/issues/29583).
 - Cypress Component Testing no longer supports `Angular` versions 13, 14, 15, and 16. The minimum supported version is now `17.2.0` in order to fully support Angular [signals](https://angular.dev/guide/signals). Addresses [#29582](https://github.com/cypress-io/cypress/issues/29582). Addressed in [#30539](https://github.com/cypress-io/cypress/pull/30539).
+- Cypress Component Testing no longer supports `Svelte` version 3. Addresses [#30492](https://github.com/cypress-io/cypress/issues/30492).
 - The `cypress/angular-signals` test harness is no longer included in the Cypress binary. Instead, signals support is now shipped with `cypress/angular`! This requires `rxjs` to be installed as a `peerDependency`. Addresses [#29606](https://github.com/cypress-io/cypress/issues/29606).
 - Cypress Component Testing no longer supports `create-react-app`. Addresses [#30028](https://github.com/cypress-io/cypress/issues/30028).
 

diff --git a/cli/types/cypress.d.ts b/cli/types/cypress.d.ts
@@ -3392,7 +3392,7 @@ declare namespace Cypress {
     type: string
 
     /**
-     * Used as the flag for `getPreset` for meta framworks, such as finding the webpack config for CRA, Angular, etc.
+     * Used as the flag for `getPreset` for meta frameworks, such as finding the webpack config for CRA, Angular, etc.
      * It is also the name of the string added to `cypress.config`
      *
      * @example
@@ -3444,12 +3444,12 @@ declare namespace Cypress {
     dependencies: (bundler: 'webpack' | 'vite', projectPath: string) => Promise<DependencyToInstall[]>
 
     /**
-     * This is used interally by Cypress for the "Create From Component" feature.
+     * This is used internally by Cypress for the "Create From Component" feature.
      */
     codeGenFramework?: 'react' | 'vue' | 'svelte' | 'angular'
 
     /**
-     * This is used interally by Cypress for the "Create From Component" feature.
+     * This is used internally by Cypress for the "Create From Component" feature.
      * @example '*.{js,jsx,tsx}'
      */
     glob?: string

diff --git a/npm/svelte/package.json b/npm/svelte/package.json
@@ -12,12 +12,12 @@
   },
   "devDependencies": {
     "@cypress/mount-utils": "0.0.0-development",
-    "svelte": "^3.49.0",
+    "svelte": "^4.2.19",
     "typescript": "~5.4.5"
   },
   "peerDependencies": {
     "cypress": ">=10.6.0",
-    "svelte": ">=3.0.0"
+    "svelte": ">=4.0.0"
   },
   "files": [
     "dist/**/*"

diff --git a/npm/svelte/rollup.config.mjs b/npm/svelte/rollup.config.mjs
@@ -1,3 +1,4 @@
 import { createEntries } from '@cypress/mount-utils/create-rollup-entry.mjs'
 
-export default createEntries({ formats: ['es', 'cjs'], input: 'src/index.ts' })
+// updated respectExternal to false due to this issue: https://github.com/Swatinem/rollup-plugin-dts/issues/162#issuecomment-1702374232
+export default createEntries({ formats: ['es', 'cjs'], input: 'src/index.ts', dtsOptions: { respectExternal: false } })
diff --git a/packages/scaffold-config/src/dependencies.ts b/packages/scaffold-config/src/dependencies.ts
@@ -121,7 +121,7 @@ export const WIZARD_DEPENDENCY_SVELTE: Cypress.CypressComponentDependency = {
   package: 'svelte',
   installer: 'svelte',
   description: 'Cybernetically enhanced web apps',
-  minVersion: '^3.0.0 || ^4.0.0',
+  minVersion: '^4.0.0',
 } as const
 
 export const WIZARD_DEPENDENCIES = [

diff --git a/packages/scaffold-config/test/unit/detect.spec.ts b/packages/scaffold-config/test/unit/detect.spec.ts
@@ -182,7 +182,7 @@ describe('detectFramework', () => {
       const projectPath = await scaffoldMigrationProject('svelte-vite-unconfigured')
 
       fakeDepsInNodeModules(projectPath, [
-        { dependency: 'svelte', version: '3.0.0' },
+        { dependency: 'svelte', version: '4.0.0' },
         { dependency: 'vite', version: v },
       ])
 
@@ -197,7 +197,7 @@ describe('detectFramework', () => {
     const projectPath = await scaffoldMigrationProject('svelte-webpack-unconfigured')
 
     fakeDepsInNodeModules(projectPath, [
-      { dependency: 'svelte', version: '3.0.0' },
+      { dependency: 'svelte', version: '4.0.0' },
       { dependency: 'webpack', version: '5.0.0' },
     ])
 

diff --git a/system-tests/projects/svelte-vite/yarn.lock b/system-tests/projects/svelte-vite/yarn.lock
diff --git a/system-tests/projects/svelte-webpack-unconfigured/package.json b/system-tests/projects/svelte-webpack-unconfigured/package.json
@@ -9,7 +9,7 @@
     "cross-env": "^7.0.3",
     "css-loader": "^5.0.1",
     "mini-css-extract-plugin": "^2.9.1",
-    "svelte": "^3.31.2",
+    "svelte": "^4.2.19",
     "svelte-loader": "^3.0.0",
     "webpack": "^5.16.0",
     "webpack-cli": "^4.10.0",

diff --git a/system-tests/projects/svelte-webpack-unconfigured/yarn.lock b/system-tests/projects/svelte-webpack-unconfigured/yarn.lock
diff --git a/system-tests/projects/svelte-webpack/package.json b/system-tests/projects/svelte-webpack/package.json
@@ -6,7 +6,7 @@
     "css-loader": "^6.7.1",
     "html-webpack-plugin": "^5.5.0",
     "mini-css-extract-plugin": "^2.9.1",
-    "svelte": "^3.44.0",
+    "svelte": "^4.2.19",
     "svelte-loader": "^3.1.3",
     "webpack": "^5.74.0",
     "webpack-dev-server": "^4.10.0"