Skip to content

Commit

Permalink
chore: remove binary build step from Linux CI
Browse files Browse the repository at this point in the history
  • Loading branch information
astone123 committed Oct 2, 2023
1 parent 9ca7883 commit 1d834a3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 35 deletions.
20 changes: 0 additions & 20 deletions .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1058,25 +1058,6 @@ commands:
name: "Waiting on Circle CI jobs: <<parameters.job-names>>"
command: node ./scripts/wait-on-circle-jobs.js --job-names="<<parameters.job-names>>"

build-binary:
steps:
- run:
name: Build the Cypress binary
no_output_timeout: "45m"
command: |
source ./scripts/ensure-node.sh
node --version
if [[ `node ./scripts/get-platform-key.js` == 'linux-arm64' ]]; then
# these are missing on Circle and there is no way to pre-install them on Arm
sudo apt-get update
sudo apt-get install -y libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb
DISABLE_SNAPSHOT_REQUIRE=1 yarn binary-build --version $(node ./scripts/get-next-version.js) --createTar
else
yarn binary-build --version $(node ./scripts/get-next-version.js) --createTar
fi
- store_artifacts:
path: cypress-dist.tgz

check-if-binary-exists:
steps:
- run:
Expand Down Expand Up @@ -2106,7 +2087,6 @@ jobs:
- restore_cached_workspace
- check-if-binary-exists
- setup_should_persist_artifacts
- build-binary
- trigger-publish-binary-pipeline

get-published-artifacts:
Expand Down
10 changes: 1 addition & 9 deletions scripts/binary/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import electron from '../../packages/electron'
import la from 'lazy-ass'
import { promisify } from 'util'
import glob from 'glob'
import tar from 'tar'

import * as packages from './util/packages'
import * as meta from './meta'
Expand Down Expand Up @@ -40,7 +39,6 @@ interface BuildCypressAppOpts {
version: string
skipSigning?: boolean
keepBuild?: boolean
createTar?: boolean
}

/**
Expand Down Expand Up @@ -78,7 +76,7 @@ async function checkMaxPathLength () {
// For debugging the flow without rebuilding each time

export async function buildCypressApp (options: BuildCypressAppOpts) {
const { platform, version, keepBuild = false, createTar } = options
const { platform, version, keepBuild = false } = options

log('#checkPlatform')
if (platform !== os.platform()) {
Expand Down Expand Up @@ -214,12 +212,6 @@ require('./packages/server/index.js')
log('#transformSymlinkRequires')
await transformRequires(meta.distDir())

// optionally create a tar of the `cypress-build` directory. This is used in CI.
if (createTar) {
log('#create tar from dist dir')
await tar.c({ file: 'cypress-dist.tgz', gzip: true, cwd: os.tmpdir() }, ['cypress-build'])
}

log(`#testDistVersion ${meta.distDir()}`)
await testDistVersion(meta.distDir(), version)

Expand Down
6 changes: 0 additions & 6 deletions scripts/binary/trigger-publish-binary-pipeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,11 @@ const { getNextVersionForBinary } = require('../get-next-version')

const { nextVersion } = await getNextVersionForBinary()

function getArtifactUrl (fileName) {
return `https://output.circle-artifacts.com/output/job/${process.env.CIRCLE_WORKFLOW_JOB_ID}/artifacts/${process.env.CIRCLE_NODE_INDEX}/${fileName}`
}

const body = JSON.stringify({
parameters: {
temp_dir: os.tmpdir(),
sha: process.env.CIRCLE_SHA1,
job_name: process.env.CIRCLE_JOB,
binary_artifact_url: getArtifactUrl('cypress-dist.tgz'),
built_source_artifact_url: getArtifactUrl('cypress-built-source.tgz'),
triggered_workflow_id: process.env.CIRCLE_WORKFLOW_ID,
triggered_job_url: process.env.CIRCLE_BUILD_URL,
branch: process.env.CIRCLE_BRANCH,
Expand Down

0 comments on commit 1d834a3

Please sign in to comment.