revert changes to getInvocationDetails to see if that breaks tests

cypress-io · Dec 17, 2024 · 125b41e · 125b41e
1 parent 81cacf8
commit 125b41e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/driver/src/cypress/error_utils.ts b/packages/driver/src/cypress/error_utils.ts
@@ -18,7 +18,7 @@ if (!Error.captureStackTrace) {
   Error.captureStackTrace = (err, fn) => {
     const stack = (new Error()).stack
 
-    ;(err as Error).stack = $stackUtils.stackWithLinesDroppedFromMarker(stack, fn?.name, false)
+    ;(err as Error).stack = $stackUtils.stackWithLinesDroppedFromMarker(stack, fn?.name)
   }
 }
 

diff --git a/packages/driver/src/cypress/stack_utils.ts b/packages/driver/src/cypress/stack_utils.ts
@@ -119,8 +119,8 @@ const getInvocationDetails = (specWindow, config) => {
     // firefox throws a different stack than chromium
     // which includes stackframes from cypress_runner.js.
     // So we drop the lines until we get to the spec stackframe (includes __cypress/tests)
-    if (specWindow.Cypress) {
-      stack = stackWithLinesDroppedFromMarker(stack, '/__cypress', !specWindow.Cypress.isBrowser('webkit'))
+    if (specWindow.Cypress && specWindow.Cypress.isBrowser('firefox')) {
+      stack = stackWithLinesDroppedFromMarker(stack, '__cypress/tests', true)
     }
 
     const details: InvocationDetails = getSourceDetailsForFirstLine(stack, config('projectRoot')) || {};