put isBrowserGivenByCli on modeOptions (#4)

* Update coreDataShape.ts * Update ProjectLifecycleManager.ts
cypress-io · Nov 3, 2024 · 11bd244 · 11bd244
1 parent 2f82876
commit 11bd244
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/packages/data-context/src/data/ProjectLifecycleManager.ts b/packages/data-context/src/data/ProjectLifecycleManager.ts
@@ -315,7 +315,7 @@ export class ProjectLifecycleManager {
   async setInitialActiveBrowser () {
     const configBrowser = this.loadedFullConfig?.defaultBrowser
 
-    if (configBrowser && !this.ctx.coreData.isBrowserGivenByCli) {
+    if (configBrowser && !this.ctx.modeOptions.isBrowserGivenByCli) {
       if (this.ctx.isRunMode) {
         this.ctx.setModeOptionsBrowser(configBrowser)
 

diff --git a/packages/data-context/src/data/coreDataShape.ts b/packages/data-context/src/data/coreDataShape.ts
@@ -143,7 +143,6 @@ interface CloudDataShape {
 
 export interface CoreDataShape {
   cliBrowser: string | null
-  isBrowserGivenByCli: boolean
   cliTestingType: string | null
   activeBrowser: FoundBrowser | null
   machineId: Promise<string | null>
@@ -183,7 +182,6 @@ export function makeCoreData (modeOptions: Partial<AllModeOptions> = {}): CoreDa
   return {
     servers: {},
     cliBrowser: modeOptions.browser ?? null,
-    isBrowserGivenByCli: modeOptions.isBrowserGivenByCli ?? false,
     cliTestingType: modeOptions.testingType ?? null,
     machineId: machineId(),
     machineBrowsers: null,