breaking: remove logic around min supported browsers (#30462)

* remove logic around min supported browsers BREAKING: remove logic around min supported browsers * changelog entry * forgot to save some changed files * update broken tests * remove another test testing unsupported browsers * Add back logic for browser validator * return if validator is undefined * update called browser * fix failing tests * fix logic of unsupported showing * add parens
cypress-io · Nov 1, 2024 · 0aa73c4 · 0aa73c4 · cypress-bot · Nov 1, 2024
1 parent 575b9b7
commit 0aa73c4
Show file tree

Hide file tree

Showing 21 changed files with 81 additions and 396 deletions.
diff --git a/cli/CHANGELOG.md b/cli/CHANGELOG.md
@@ -7,6 +7,7 @@ _Released 12/3/2024 (PENDING)_
 
 - Removed support for Node.js 16 and Node.js 21. Addresses [#29930](https://github.com/cypress-io/cypress/issues/29930).
 - Prebuilt binaries for Linux are no longer compatible with Linux distributions based on glibc <2.28, for example: Ubuntu 14-18, RHEL 7, CentOS 7, Amazon Linux 2. Addresses [#29601](https://github.com/cypress-io/cypress/issues/29601).
+- Cypress now only officially supports the latest 3 major versions of Chrome, Firefox, and Edge - older browser versions may still work, but we recommend keeping your browsers up to date to ensure compatibility with Cypress. A warning will no longer be displayed on browser selection in the Launchpad for any 'unsupported' browser versions. Additionally, the undocumented `minSupportedVersion` property has been removed from `Cypress.browser`. Addressed in [#30462](https://github.com/cypress-io/cypress/pull/30462).
 - The `delayMs` option of `cy.intercept()` has been removed. This option was deprecated in Cypress 6.4.0. Please use the `delay` option instead. Addressed in [#30463](https://github.com/cypress-io/cypress/pull/30463).
 - The `experimentalFetchPolyfill` configuration option was removed. This option was deprecated in Cypress 6.0.0. We recommend using `cy.intercept()` for handling fetch requests. Addressed in [#30466](https://github.com/cypress-io/cypress/pull/30466).
 - We removed yielding the second argument of `before:browser:launch` as an array of browser arguments. This behavior has been deprecated since Cypress 4.0.0. Addressed in [#30460](https://github.com/cypress-io/cypress/pull/30460).

diff --git a/cli/types/cypress.d.ts b/cli/types/cypress.d.ts
@@ -118,11 +118,7 @@ declare namespace Cypress {
      */
     warning?: string
     /**
-     * The minimum majorVersion of this browser supported by Cypress.
-     */
-    minSupportedVersion?: number
-    /**
-     * If `true`, this browser is too old to be supported by Cypress.
+     * If `true`, this browser version is not supported in Cypress.
      */
     unsupportedVersion?: boolean
   }

diff --git a/packages/app/src/settings/project/ConfigCode.cy.tsx b/packages/app/src/settings/project/ConfigCode.cy.tsx
@@ -190,7 +190,6 @@ describe('<ConfigCode />', () => {
           browser.displayName && cy.contains(`displayName: '${browser.displayName}',`)
           browser.version && cy.contains(`version: '${browser.version}',`)
           browser.path && cy.contains(`path: '${browser.path}',`)
-          browser.minSupportedVersion && cy.contains(`minSupportedVersion: ${browser.minSupportedVersion},`)
           browser.majorVersion && cy.contains(`majorVersion: ${browser.majorVersion},`)
         })
       } else {

diff --git a/packages/errors/__snapshot-html__/UNSUPPORTED_BROWSER_VERSION.html b/packages/errors/__snapshot-html__/UNSUPPORTED_BROWSER_VERSION.html
diff --git a/packages/errors/src/errors.ts b/packages/errors/src/errors.ts
@@ -1416,6 +1416,7 @@ export const AllCypressErrors = {
 
         https://on.cypress.io/component-testing`
   },
+
   UNSUPPORTED_BROWSER_VERSION: (errorMsg: string) => {
     return errTemplate`${fmt.off(errorMsg)}`
   },

diff --git a/packages/frontend-shared/cypress/fixtures/config.json b/packages/frontend-shared/cypress/fixtures/config.json
@@ -23,7 +23,6 @@
         "displayName": "Chrome",
         "version": "97.0.4692.71",
         "path": "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome",
-        "minSupportedVersion": 64,
         "majorVersion": 97
       },
       {
@@ -33,7 +32,6 @@
         "displayName": "Firefox",
         "version": "95.0.2",
         "path": "/Applications/Firefox.app/Contents/MacOS/firefox",
-        "minSupportedVersion": 86,
         "majorVersion": 95
       },
       {

diff --git a/packages/frontend-shared/cypress/support/mock-graphql/longBrowsersList.ts b/packages/frontend-shared/cypress/support/mock-graphql/longBrowsersList.ts
@@ -84,9 +84,9 @@ export const longBrowsersList = [
     displayName: 'Edge Beta',
     family: 'chromium',
     channel: 'beta',
-    version: 'unsupported',
+    version: '85.0.309.71',
     path: '/Applications/Microsoft Edge Beta.app/Contents/MacOS/Microsoft Edge Beta',
-    majorVersion: '79',
+    majorVersion: '85',
     isFocusSupported: true,
     isVersionSupported: false,
     disabled: false,
@@ -126,9 +126,8 @@ export const longBrowsersList = [
     version: '69.0.1',
     path: '/Applications/Firefox/Contents/MacOS/Firefox',
     majorVersion: '69',
-    unsupportedVersion: true,
     isFocusSupported: true,
-    isVersionSupported: false,
+    isVersionSupported: true,
     disabled: true,
   },
   {
@@ -140,9 +139,8 @@ export const longBrowsersList = [
     version: '75.0.1',
     path: '/Applications/Firefox/Contents/MacOS/Firefox',
     majorVersion: '75',
-    unsupportedVersion: true,
     isFocusSupported: true,
-    isVersionSupported: false,
+    isVersionSupported: true,
     disabled: true,
   },
   {
@@ -169,7 +167,7 @@ export const longBrowsersList = [
     path: '/Applications/Firefox Nightly/Contents/MacOS/Firefox Nightly',
     majorVersion: '69',
     isFocusSupported: false,
-    isVersionSupported: false,
+    isVersionSupported: true,
     disabled: true,
   },
   {
@@ -182,7 +180,7 @@ export const longBrowsersList = [
     path: '/Applications/Fake Browser/Contents/MacOS/Fake Browser',
     majorVersion: '79',
     isFocusSupported: false,
-    isVersionSupported: false,
+    isVersionSupported: true,
     disabled: true,
   },
 ] as const
diff --git a/packages/frontend-shared/src/gql-components/HeaderBarContent.cy.tsx b/packages/frontend-shared/src/gql-components/HeaderBarContent.cy.tsx
@@ -53,11 +53,6 @@ describe('<HeaderBarContent />', { viewportWidth: 1000, viewportHeight: 750 }, (
     })
 
     cy.contains('Unsupported browser').should('be.visible')
-
-    /*
-      TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23436
-      cy.percySnapshot('unsupported browser tooltip')
-    */
   })
 
   describe('breadcrumbs', () => {

diff --git a/packages/frontend-shared/src/gql-components/topnav/VerticalBrowserListItems.vue b/packages/frontend-shared/src/gql-components/topnav/VerticalBrowserListItems.vue
@@ -11,7 +11,6 @@
         'cursor-pointer': !browser.disabled && browser.isVersionSupported
       }"
       data-cy="top-nav-browser-list-item"
-
       :data-browser-id="browser.id"
       @click="handleBrowserChoice(browser)"
     >
@@ -24,7 +23,7 @@
       <div class="grow">
         <div>
           <button
-            class="font-medium box-border focus:outline-none"
+            class="box-border font-medium focus:outline-none"
             :class="{
               'text-indigo-500 group-hover:text-indigo-700': !browser.isSelected && !browser.disabled && browser.isVersionSupported,
               'text-jade-700': browser.isSelected,
@@ -39,19 +38,15 @@
             "
           >
             {{ t('topNav.version') }} {{ browser.majorVersion }}
-            <span v-if="browser.version === 'unsupported'">
-              ({{ t('topNav.versionUnsupported') }})
+            <span v-if="!browser.isVersionSupported">
+              (Unsupported)
             </span>
           </div>
         </div>
       </div>
       <div>
-        <div
-          class="flex h-full items-center align-middle"
-        >
-          <template
-            v-if="browser.isSelected"
-          >
+        <div class="flex items-center h-full align-middle">
+          <template v-if="browser.isSelected">
             <div data-cy="top-nav-browser-list-selected-item">
               <i-cy-circle-check_x24 class="h-[24px] w-[24px] icon-dark-jade-100 icon-light-jade-500" />
             </div>
@@ -65,7 +60,7 @@
                 />
                 <template #popper>
                   <div class="text-center p-2 text-gray-300 text-[14px] leading-[20px]">
-                    <div class="font-medium text-white mb-2">
+                    <div class="mb-2 font-medium text-white">
                       Unsupported browser
                     </div>
                     {{ browser.warning }}

diff --git a/packages/frontend-shared/src/locales/en-US.json b/packages/frontend-shared/src/locales/en-US.json
@@ -316,7 +316,6 @@
   "topNav": {
     "released": "Released",
     "version": "Version",
-    "versionUnsupported": "Unsupported",
     "installed": "Installed",
     "latest": "Latest",
     "seeAllReleases": "See all releases",

diff --git a/packages/launcher/__snapshots__/browsers_spec.ts.js b/packages/launcher/__snapshots__/browsers_spec.ts.js
@@ -10,7 +10,6 @@ exports['browsers returns the expected list of browsers 1'] = [
       'chrome',
       'google-chrome-stable',
     ],
-    'minSupportedVersion': 64,
   },
   {
     'name': 'chromium',
@@ -22,7 +21,6 @@ exports['browsers returns the expected list of browsers 1'] = [
       'chromium-browser',
       'chromium',
     ],
-    'minSupportedVersion': 64,
   },
   {
     'name': 'chrome',
@@ -31,7 +29,6 @@ exports['browsers returns the expected list of browsers 1'] = [
     'displayName': 'Chrome Beta',
     'versionRegex': {},
     'binary': 'google-chrome-beta',
-    'minSupportedVersion': 64,
   },
   {
     'name': 'chrome',
@@ -40,7 +37,6 @@ exports['browsers returns the expected list of browsers 1'] = [
     'displayName': 'Canary',
     'versionRegex': {},
     'binary': 'google-chrome-canary',
-    'minSupportedVersion': 64,
   },
   {
     'name': 'firefox',
@@ -49,7 +45,6 @@ exports['browsers returns the expected list of browsers 1'] = [
     'displayName': 'Firefox',
     'versionRegex': {},
     'binary': 'firefox',
-    'minSupportedVersion': 86,
   },
   {
     'name': 'firefox',
@@ -61,7 +56,6 @@ exports['browsers returns the expected list of browsers 1'] = [
       'firefox-developer-edition',
       'firefox',
     ],
-    'minSupportedVersion': 86,
   },
   {
     'name': 'firefox',
@@ -73,7 +67,6 @@ exports['browsers returns the expected list of browsers 1'] = [
       'firefox-nightly',
       'firefox-trunk',
     ],
-    'minSupportedVersion': 86,
   },
   {
     'name': 'edge',
@@ -85,7 +78,6 @@ exports['browsers returns the expected list of browsers 1'] = [
       'edge',
       'microsoft-edge',
     ],
-    'minSupportedVersion': 79,
   },
   {
     'name': 'edge',
@@ -97,7 +89,6 @@ exports['browsers returns the expected list of browsers 1'] = [
       'edge-canary',
       'microsoft-edge-canary',
     ],
-    'minSupportedVersion': 79,
   },
   {
     'name': 'edge',
@@ -109,7 +100,6 @@ exports['browsers returns the expected list of browsers 1'] = [
       'edge-beta',
       'microsoft-edge-beta',
     ],
-    'minSupportedVersion': 79,
   },
   {
     'name': 'edge',
@@ -121,6 +111,5 @@ exports['browsers returns the expected list of browsers 1'] = [
       'edge-dev',
       'microsoft-edge-dev',
     ],
-    'minSupportedVersion': 79,
   },
 ]
diff --git a/packages/launcher/__snapshots__/darwin_spec.ts.js b/packages/launcher/__snapshots__/darwin_spec.ts.js
@@ -10,7 +10,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
       'chrome',
       'google-chrome-stable',
     ],
-    'minSupportedVersion': 64,
     'path': '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
     'version': 'someVersion',
     'findAppParams': {
@@ -30,7 +29,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
       'chromium-browser',
       'chromium',
     ],
-    'minSupportedVersion': 64,
     'path': '/Applications/Chromium.app/Contents/MacOS/Chromium',
     'version': 'someVersion',
     'findAppParams': {
@@ -47,7 +45,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'displayName': 'Chrome Beta',
     'versionRegex': {},
     'binary': 'google-chrome-beta',
-    'minSupportedVersion': 64,
     'path': '/Applications/Google Chrome Beta.app/Contents/MacOS/Google Chrome Beta',
     'version': 'someVersion',
     'findAppParams': {
@@ -64,7 +61,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'displayName': 'Canary',
     'versionRegex': {},
     'binary': 'google-chrome-canary',
-    'minSupportedVersion': 64,
     'path': '/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary',
     'version': 'someVersion',
     'findAppParams': {
@@ -81,7 +77,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
     'displayName': 'Firefox',
     'versionRegex': {},
     'binary': 'firefox',
-    'minSupportedVersion': 86,
     'path': '/Applications/Firefox.app/Contents/MacOS/firefox',
     'version': 'someVersion',
     'findAppParams': {
@@ -101,7 +96,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
       'firefox-developer-edition',
       'firefox',
     ],
-    'minSupportedVersion': 86,
     'path': '/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox',
     'version': 'someVersion',
     'findAppParams': {
@@ -121,7 +115,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
       'firefox-nightly',
       'firefox-trunk',
     ],
-    'minSupportedVersion': 86,
     'path': '/Applications/Firefox Nightly.app/Contents/MacOS/firefox',
     'version': 'someVersion',
     'findAppParams': {
@@ -141,7 +134,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
       'edge',
       'microsoft-edge',
     ],
-    'minSupportedVersion': 79,
     'path': '/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge',
     'version': 'someVersion',
     'findAppParams': {
@@ -161,7 +153,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
       'edge-canary',
       'microsoft-edge-canary',
     ],
-    'minSupportedVersion': 79,
     'path': '/Applications/Microsoft Edge Canary.app/Contents/MacOS/Microsoft Edge Canary',
     'version': 'someVersion',
     'findAppParams': {
@@ -181,7 +172,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
       'edge-beta',
       'microsoft-edge-beta',
     ],
-    'minSupportedVersion': 79,
     'path': '/Applications/Microsoft Edge Beta.app/Contents/MacOS/Microsoft Edge Beta',
     'version': 'someVersion',
     'findAppParams': {
@@ -201,7 +191,6 @@ exports['darwin browser detection detects browsers as expected 1'] = [
       'edge-dev',
       'microsoft-edge-dev',
     ],
-    'minSupportedVersion': 79,
     'path': '/Applications/Microsoft Edge Dev.app/Contents/MacOS/Microsoft Edge Dev',
     'version': 'someVersion',
     'findAppParams': {
-Original file line number
+Diff line change
@@ Expand Up / @@ -1416,6 +1416,7 @@ export const AllCypressErrors = { @@
             https://on.cypress.io/component-testing`
       },
       UNSUPPORTED_BROWSER_VERSION: (errorMsg: string) => {
         return errTemplate`${fmt.off(errorMsg)}`
       },
@@ Expand Down @@