docs: update Docker image examples to supported Node.js 18 #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | bf5a728 |
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
nagash77
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js
18and20 and aboveare the only versions currently supported by Cypress according to Getting Started > Installing Cypress > System requirements > Node.js therefore examples and templates should only use these versions.Out of range examples Node.js
12or14are updated to align with existing examples using Node.js18.x.Changes
cypress/base
Update
cypress/base:14tocypress/base:18.12.1(Leave references to
cypress/base:18.12.1as they are.)cypress/browsers
Update
cypress/browsers:node12.14.1-chrome85-ff81tocypress/browsers:node18.12.0-chrome106-ff106(Leave references to
cypress/browsers:node18.12.0-chrome106-ff106as they are.)cypress/included
cypress/includedwith a version reference, so no changes needed.)Outlook
According to the Node.js Release schedule Node.js
18enters end-of-life on April 30, 2025, so the Docker versions used in the examples are good for the next year and a half. It would however also be worthwhile optionally considering updating to Node.js20when this version takes on theLTSrole next month on Oct 24, 2023. In this case the CI templates on Cypress Cloud (which are currently partially out-of-date) should also be updated to Node.js20.