Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Mike McCready <[email protected]>
  • Loading branch information
mjhenkes and MikeMcC399 authored Jul 12, 2023
1 parent 7d78203 commit dcea3ed
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/guides/core-concepts/introduction-to-cypress.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -1351,7 +1351,7 @@ assertions_.
#### Example #1: Implicit Assertion

```js
// because .get() has a implicit assertion
// because .get() has an implicit assertion
// that this element exists, it can time out and fail
cy.get('.mobile-nav')
```
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/guides/screenshots-and-videos.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ possibly uploading it to Cypress Cloud.
:::cypress-config-example

In addition to enabling or disabling video compress, you can specify the CRF
value used to compress the video. Here is some common scenario:
value used to compress the video. Here are some common scenarios:

- If the machine is encoding the video slowly (which is often the case for
virtual machines that use less CPU cores), try increasing the CRF value.
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/references/best-practices.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ Why you shouldn't do this in end-to-end tests:
- Resetting tests is much slower than adding more assertions

It is common for tests in Cypress to issue 30+ commands. Because nearly every
command has a implicit assertions (and can therefore fail), even by limiting
command has an implicit assertion (and can therefore fail), even by limiting
your assertions you're not saving yourself anything because **any single command
could implicitly fail**.

Expand Down

0 comments on commit dcea3ed

Please sign in to comment.