chore: add Node.js 16.17.0 and 18.6.0 #736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lmiller1990
commented
Aug 31, 2022
| @@ -436,24 +436,24 @@ workflows: | |||
| jobs: | |||
There was a problem hiding this comment.
Was this meant to change? I just followed the instructions in https://github.com/cypress-io/cypress-docker-images/blob/master/CONTRIBUTING.md
There was a problem hiding this comment.
Yeah this changes depending on what the last generated image is.
admah
suggested changes
Sep 1, 2022
There was a problem hiding this comment.
@lmiller1990 you'll need to break these up into two separate PRs (16.17.0 and 18.6.0). With the changes to circle.yml we don't have the ability to do multiple image releases at the same time currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some problems with Node.js specific versions like 16.17 and 18.6, eg
cypress-io/cypress#22795
Need the correct docker images to be able to add regressions tests.