chore: update angular-standalone to v19 (need prebuilt binary to work) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
chore/update_angular_standalone_to_v19
branch
from
57a30cb to
d7fe7ea
Compare
AtofStryker
commented
Nov 26, 2024
| "@types/jasmine": "~5.1.0", | ||
| "autoprefixer": "^10.4.20", | ||
| "cypress": "^13.15.1", | ||
| "jasmine-core": "~5.2.0", | ||
| "cypress": "https://cdn.cypress.io/beta/npm/13.15.2/darwin-arm64/feat/support_angular_19-438f97845003bb30d5d10cadffe0b52570b634b8/cypress.tgz", |
There was a problem hiding this comment.
we will need to update these after we publish cypress 14 as the dev tag (See release checklist cypress-io/cypress#30305)
mschile
reviewed
Dec 2, 2024
| @@ -3,6 +3,7 @@ import { ButtonComponent } from './button.component'; | |||
|
|
|||
| @Component({ | |||
| template: ` <app-button> Click Me </app-button> `, | |||
| standalone: false, | |||
There was a problem hiding this comment.
Are we able to just convert this to a standalone component?
There was a problem hiding this comment.
we can't because we are using template syntax, which means the testing module needs access to the component. Otherwise, it would be fine
mschile
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the angular standalone example to
v19