Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data store mgr: Increase the max number of workflows to 100 #570

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

oliver-sanders
Copy link
Member

Easy way to test:

  • Launch a bunch of workflows.
  • Run cylc pause '*'.
  • The workflows that are being updated will change state to paused, the ones which aren't will stay as running.

Try adjusting the max_threads value to a lower number.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added the bug Something isn't working label Mar 26, 2024
@oliver-sanders oliver-sanders added this to the 1.4.4 milestone Mar 26, 2024
@oliver-sanders oliver-sanders self-assigned this Mar 26, 2024
@wxtim
Copy link
Member

wxtim commented Mar 26, 2024

On a practical basis this seems to work, though very unperformant on my Intel® Core™ i5-2520M CPU @ 2.50GHz × 4
Screen Shot 2024-03-26 at 16 07 56

Screen Shot 2024-03-26 at 16 08 06

The ghosting of the icons with state stopped when they are actually playing in the workflow sidebar is something which is happening before and after this change. Is that a known issue?

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read code
  • Tried change

@oliver-sanders
Copy link
Member Author

Is that a known issue?

Look at your UIS logs, you should see attempts to connect to the workflows there, if there were issues connecting they should be logged too.

@MetRonnie
Copy link
Member

On a practical basis this seems to work, though very unperformant on my Intel® Core™ i5-2520M CPU @ 2.50GHz × 4

(It's easier to test with workflows running on the Cylc servers)

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Reproduced the 8-workflow limit on master/1.4.x and not able to reproduce on this branch

@oliver-sanders oliver-sanders merged commit 1e72de8 into cylc:1.4.x Mar 27, 2024
5 of 6 checks passed
@oliver-sanders oliver-sanders deleted the 569 branch March 27, 2024 08:41
@MetRonnie

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants