-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset WbFieldRef->last_update
After Simulation Reset
#6758
Open
CoolSpy3
wants to merge
18
commits into
cyberbotics:master
Choose a base branch
from
DeepBlueRobotics:update-fields-on-reset
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reset WbFieldRef->last_update
After Simulation Reset
#6758
CoolSpy3
wants to merge
18
commits into
cyberbotics:master
from
DeepBlueRobotics:update-fields-on-reset
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, after the simulation is reset by a controller, supervisors can occasionally read stale values from fields (see the linked issue for details). This PR updates Webots to broadcast a
C_SUPERVISOR_SIMULATION_RESET
message whenever the simulation is reset. It then updates controllers to respond to this message by resetting thelast_update
field of all of their field references. This effectively marks their cached data as invalid, so when the controller tries to read the value, it will re-fetch it from Webots.Related Issues
This pull-request fixes issue #6670.
Tasks
Add the list of tasks of this PR.