Fix #140 #141
Merged
Fix #140 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve the taggable_type. Add same to the anonymous class in getQualifiedPivotTableName().
…elations does for a pivot anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use getMorphClass() instead of get_class to resolve the taggable_type. Add same to the anonymous class in getQualifiedPivotTableName().
Thank you for helping to make this package better!
Please make sure you've read CONTRIBUTING.md
before submitting your pull request, and that you have:
See issue #140 for info.
used the PSR-2 Coding Standard
added tests
No change to tests. I don't know how to change Relation::enforceMorphMap() dynamically.
documented any change in behaviour (e.g. updated the
README.md, etc.)No change to behavior.
only submitted one pull request per feature
It's a small change.