Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mise + eslint to gist-web + upgrade node to 20 #71

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

karngyan
Copy link
Member

@karngyan karngyan commented Oct 19, 2024

Recently pushed a change here https://github.com/customerio/gist-web/pull/68/files where a method was not imported but used, as vscode din't complain.

Changes

  • Adds a basic mise config for node version.
  • Upgrade node to 20 for builds. (Gonna do a round of testing across cdp and sdk before merging)
  • This adds a minimal eslint config, which would only add warnings in the editor. No pre commit hooks or build blockers yet.
  • A future PR would have all the eslint warnings resolved. But I don't wanna do that without end to end manual testing of the generated script.

Current errors:
image

  • Planning on a future set of changes with prettier, typescript-ifying this repo, and also adding automated tests so folks can make changes to it confidently.

Now at least devs would see errors like:

image

image

@karngyan karngyan changed the title add mise + eslint to gist-web add mise + eslint to gist-web + upgrade node to 20 Oct 19, 2024
@stephen-pope-customer-io
Copy link
Contributor

stephen-pope-customer-io commented Oct 21, 2024

This is the main portion of https://linear.app/customerio/issue/INAPP-12846/add-linter-to-gist-web

@stephen-pope-customer-io stephen-pope-customer-io merged commit 103a950 into develop Nov 15, 2024
1 check passed
@stephen-pope-customer-io stephen-pope-customer-io deleted the eslint-gist-web branch November 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants