Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new handle session #366

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

new handle session #366

wants to merge 4 commits into from

Conversation

alexviquez
Copy link
Member

@alexviquez alexviquez commented Aug 23, 2023

The last implementation had the issue of creating a session context for every request. This has been resolved by creating a Retry adapter. Thanks to @matin for the suggestion

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #366 (bd175cf) into main (2447f60) will not change coverage.
The diff coverage is 100.00%.

❗ Current head bd175cf differs from pull request most recent head e543b3d. Consider uploading reports for the commit e543b3d to get more accurate results

@@            Coverage Diff            @@
##              main      #366   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1082      1087    +5     
=========================================
+ Hits          1082      1087    +5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cuenca/http/client.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2447f60...e543b3d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant