Console commands should be consistent when using required flag

cubex · Oct 30, 2014 · 41632a4 · 41632a4
1 parent 6d1020a
commit 41632a4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/src/Console/ConsoleCommand.php b/src/Console/ConsoleCommand.php
@@ -184,16 +184,6 @@ protected function createOptionsFromPublic(
         )->getDescription();
       }
 
-      if($propBlock->hasTag('required') && $argsAdded !== true)
-      {
-        $this->addArgument(
-          $property->getName(),
-          InputArgument::REQUIRED,
-          $description
-        );
-        continue;
-      }
-
       if($propBlock->hasTag('valuerequired'))
       {
         $mode = InputOption::VALUE_REQUIRED;

diff --git a/tests/Cubex/Console/ConsoleCommandTest.php b/tests/Cubex/Console/ConsoleCommandTest.php
@@ -31,7 +31,7 @@ public function testClassDocBlocks()
     $def     = $command->getDefinition();
     $this->assertEquals(
       'This should become a named parameter',
-      $def->getArgument('demand')->getDescription()
+      $def->getOption('demand')->getDescription()
     );
     $this->assertFalse($def->getOption('on')->acceptValue());