Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have addressed All Issues #14 and #15 #18

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tornikeshavishvili
Copy link
Contributor

Hi

I have addressed All Issues #14 and #15

I believe in one commit i accidently misspelled the word. I apologize.

Also tested on windows pc and android phone.

Can not wait for your feedback

@abhisawesome
Copy link
Member

@tornikeshavishvili It contains so many bugs in node:16 version. Can you check it

@tornikeshavishvili
Copy link
Contributor Author

tornikeshavishvili commented Nov 6, 2022

@tornikeshavishvili It contains so many bugs in node:16 version. Can you check it

@abhisawesome I have addresed two more issues.

The fact that this repository has bugs, gives us opportunities. I want to collaborate with you.
Lest work this way:

  1. please, review and test my commits
  2. Merge branches
  3. Publish updated package on npm (We need it on npm)
  4. After this, lets mark this repository as "contributions-welcome" to attract more collaborators
  5. When you do above steps, we need to work iteratively, "bug by bug": You register here bugs/ideas and i will address them. If necessary we can even make video calls or somethin like this
  6. I have some more ideas.

Thanks
Tornike

@tornikeshavishvili
Copy link
Contributor Author

Hi

Could you please tell me how should i do multiple pull requests? because my repository already contains commits for al issues. Also i am new here :|

Thanks
Tornike

@abhisawesome
Copy link
Member

abhisawesome commented Nov 7, 2022

Hi

Could you please tell me how should i do multiple pull requests? because my repository already contains commits for al issues. Also i am new here :|

Thanks Tornike

Please ping me on any social media. Details are in my github profile https://github.com/abhisawesome/

@tornikeshavishvili

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants