Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): fix unhandled timestamp unwrapping in df/transform_response #8952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 13, 2024

This PR fixes timestamp parsing handling unwrapping that may lead to panic:

thread 'tokio-runtime-worker' panicked at cube/rust/cubesql/cubesql/src/compile/engine/df/scan.rs:1133:86:
called `Option::unwrap()` on a `None` value

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:39am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:39am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:39am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:39am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:39am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:39am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:39am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 0:39am

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.65%. Comparing base (211d1c1) to head (5deb2a3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 42.85% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8952   +/-   ##
=======================================
  Coverage   82.65%   82.65%           
=======================================
  Files         221      221           
  Lines       78303    78308    +5     
=======================================
+ Hits        64722    64728    +6     
+ Misses      13581    13580    -1     
Flag Coverage Δ
cubesql 82.65% <42.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KSDaemon KSDaemon marked this pull request as ready for review November 13, 2024 11:47
@KSDaemon KSDaemon requested a review from a team as a code owner November 13, 2024 11:47
@KSDaemon KSDaemon force-pushed the fix/unwrap-in-transform-response branch from e7b4a80 to 5deb2a3 Compare November 13, 2024 12:39
@KSDaemon KSDaemon requested a review from ovr November 13, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants