fix(dev_env_setup): use relative packages everywhere #8910
Conversation
github-actions
bot
added
the
pr:community
| @@ -12,145 +12,75 @@ cd "$SCRIPT_DIR" | |||
| echo "Running 'yarn install' in the root directory..." | |||
| yarn install | |||
|
|
|||
| # Step 2: Run yarn build in the root directory | |||
| echo "Running 'yarn build' in the root directory..." | |||
| yarn build | |||
There was a problem hiding this comment.
originally yarn build fires the rollup to build all the UMDs/ESMs in packages... You switched to trying running yarn build inside each pkg. But does this produce the same output?
Taking package packages/cubejs-client-core as an example:
There is no build script in package.json and there is no ts files. So new version won't do anything, while original rollup will prepare UMD for it.
| do | ||
| echo "Linking @cubejs-backend/$driver in packages/cubejs-server-core..." |
There was a problem hiding this comment.
Are you sure linking drivers in server-core is no longer needed for proper working?
| if [ -d "$package" ]; then | ||
| package_name=$(node -p "require('$package/package.json').name") | ||
| echo "Linking $package_name..." | ||
| yarn link "$package_name" |
There was a problem hiding this comment.
It's probably good to cleanup the scripts in root package.json to remove potential confusion for those who will find it and try to use but it is outdated and not actual anymore. Like "link:dev"
Check List
Description of Changes Made (if issue reference is not provided)
This solution ensures that all related packages work together seamlessly without concern for missing links.