fix(jdbc-driver): Log errors from connection pool factory

generic-pool will just silently throw those away, so we should at least log them
cube-js · Nov 12, 2024 · 1702928 · 1702928
1 parent 3fe838f
commit 1702928
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/packages/cubejs-jdbc-driver/src/JDBCDriver.ts b/packages/cubejs-jdbc-driver/src/JDBCDriver.ts
@@ -183,6 +183,14 @@ export class JDBCDriver extends BaseDriver {
       acquireTimeoutMillis: 120000,
       ...(poolOptions || {})
     }) as ExtendedPool;
+
+    // https://github.com/coopernurse/node-pool/blob/ee5db9ddb54ce3a142fde3500116b393d4f2f755/README.md#L220-L226
+    this.pool.on('factoryCreateError', (err) => {
+      this.databasePoolError(err);
+    });
+    this.pool.on('factoryDestroyError', (err) => {
+      this.databasePoolError(err);
+    });
   }
 
   protected async getCustomClassPath() {