Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and add test coverage for HTTP Client #1222

Merged
merged 5 commits into from
Sep 28, 2024
Merged

Refactor and add test coverage for HTTP Client #1222

merged 5 commits into from
Sep 28, 2024

Conversation

akabishau
Copy link
Collaborator

This PR includes:

  • renaming HttpService to HttpClient - more logical, doesn't contain business logic
  • removing error handling from HTTP Client level - errors will propagate to callers
  • simplifying V2 api client breaking loop pagination logic for fetching studies
  • comprehensive test coverage for HttpClient module (business logic related configuration, success and various error scenarios using Webmock stubbing)

@akabishau akabishau requested a review from micronix September 17, 2024 01:00
@akabishau akabishau force-pushed the refactor-and-test-http-client branch from 1c2b287 to 89f54d9 Compare September 17, 2024 01:06
@akabishau akabishau force-pushed the refactor-and-test-http-client branch from 89f54d9 to ed547e6 Compare September 17, 2024 19:22
@akabishau akabishau merged commit 9f27ea8 into refactor/api-networking Sep 28, 2024
1 check passed
@akabishau akabishau deleted the refactor-and-test-http-client branch September 28, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micronix micronix Awaiting requested review from micronix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akabishau