Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AACT-603: Create design_groups_data method in v2 processor #1117

Merged
merged 3 commits into from
Dec 21, 2023
Merged

AACT-603: Create design_groups_data method in v2 processor #1117

merged 3 commits into from
Dec 21, 2023

Conversation

Javier-Jimenez-18
Copy link
Collaborator

  • Created design_groups_data mapper method in the v2 processor.
  • Added new column group_intervention_names to design_groups table and updated design_groups_data method.
  • Created RSpec test case to test the design_groups_data method.
  • All 7 Test Cases PASS in processor_v2_spec.rb:
Screen Shot 2023-12-13 at 4 14 20 PM

@Javier-Jimenez-18 Javier-Jimenez-18 self-assigned this Dec 13, 2023
micronix
micronix requested changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@micronix micronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the addition of the group_intervention_names.

  1. Rollback the migration
  2. Delete the migration
  3. Remove the column from the tests

In addition remove the config/connections.yml file

@Javier-Jimenez-18
Undid the addition of the column group_intervention_names and reverte…
3521ab4 
…d to previous migration. Deleted migration file, updated method design_groups_data and updated RSpec test file.
@Javier-Jimenez-18
Copy link
Collaborator Author

  • Undid the addition of the group_intervention_names column
  • Rollback the migration and deleted the migration file
  • Removed the column from method design_groups_data and from the RSpec test
  • Removed the config/connections.yml file

Test case for method design_groups_data PASS and processor_v2_spec file PASS:

Screen Shot 2023-12-15 at 11 03 01 PM

micronix
micronix approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@micronix micronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@micronix micronix merged commit cb71a49 into dev Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micronix micronix micronix approved these changes

@kholtzman5610 kholtzman5610 Awaiting requested review from kholtzman5610

Assignees

@Javier-Jimenez-18 Javier-Jimenez-18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Javier-Jimenez-18 @micronix