Kick up max_files default 10k → 50k #514
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I do understand that anyone can
let g:ctrlp_max_files = 50000
or whatever in their own vimrc. Many people do change that.However, I sincerely believe that 10k files is way too low for such an awesome plugin.
You see, it isn't hard to navigate a small repo. The project is already a mess at the point when you reach out for "bigger tools" like CtrlP. Further, when you do pull out those tools, you usually want them to work. Nobody likes unreliable tools.
To substantiate, here I have a Linux kernel tree of a particular version. Cloc says, there're
46715 text files.
46k files. Sure enough, as I went with the defaults, many files I know are there — fail to be found via CtrlP. This undermines my trust in the tool; besides frustrating, I immediately recount the previous occurrences the tool failed on me, and just start wanting ever more to ditch it and find something else.I bet, too many people will, irrationally or not, go the ditching route — rather than go distract themselves with config reading and option tweaking. Even less so, submitting PRs.
So, well... I know, changing defaults is often met with reluctance. But you have no risk here. Just raise the limit... please. This line hasn't been touched since 2012!
Thanks in advance, and solid gratitude for what you do.