Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave functionality #472

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

droberts-ctrlo
Copy link
Contributor

No description provided.

- Initial version appears to work as required and expected.
- Added cancel button to clear data
- Removed stale configs
- Removed unnecessary libraries from `package.json`
- Updated ESLint to latest version
- Updated ESLint config to latest version
- Run ESLint on all relevant files and fixed where suggested whilst retaining full functionality
- Removed stale requirements within webpack.config.js
Also fix conflicts
@droberts-ctrlo
Copy link
Contributor Author

This is still work in progress - just providing current version to start review process as necessary.

- Merge "broke" some components - these have been fixed
- Made submit buttons clear saved data
- Removed "Delete" button from autosave modal
@droberts-ctrlo
Copy link
Contributor Author

Should be ready for merge

  • Local JS Unit Tests: pass
  • Local Cypress Test: pass
  • Local Perl Unit Tests: fail (Error: DBIx::Class::Storage::DBI::catch {...} (): Can't call method "app" on an undefined value at /home/droberts/perl5/lib/perl5/Dancer2/Plugin/LogReport.pm line 250. at /home/droberts/source/gads/lib/GADS.pm line 113)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant