Cleaned up common #446
Merged
Cleaned up common #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added typings for JSTree to `package.json` - Moved common mocks into own file - Ensured these mocks are used within the system as appropriate
- Abstracted out AJAX uploads to use control where it is felt it is necessary. - Removed usages of `fetch`, `XMLHttpRequest`, and `blueimp` where it has been possible and/or sensible - Removed blueimp library (reduced bloat)
Removed unnecessary functions that mirror functionality already available in JQuery, updated tests, and other files that were utilising these functions. Also created an interface and (stub) class for testing Element functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REQUIRES #444 MERGING FIRST
Removed unnecessary functions that mirror functionality already available in JQuery, updated tests, and other files that were utilising these functions. Also created an interface and (stub) class for testing Element functions.