Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Use AxiosMockAdapter throughout README #385

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jun 6, 2024

import MockAdapter from 'axios-mock-adapter'

works too, but AxiosMockAdapter is a preferred term.

@exoego exoego changed the title fix: AxiosMockAdapter is no more fix: AxiosMockAdapter is no more available Jun 7, 2024
@exoego exoego changed the title fix: AxiosMockAdapter is no more available fix: AxiosMockAdapter is no longer available Jun 7, 2024
@exoego
Copy link
Contributor Author

exoego commented Aug 5, 2024

@marcbachmann Could you take a look?

@marcbachmann
Copy link
Collaborator

I'm not sure how this would fix anything. you need to import AxiosMockAdapter instead of MockAdapter

@exoego
Copy link
Contributor Author

exoego commented Aug 5, 2024

Hmm, but

// works
import MockAdapter from 'axios-mock-adapter'

// don't
import AxiosMockAdapter from 'axios-mock-adapter'

@exoego
Copy link
Contributor Author

exoego commented Aug 5, 2024

Ah sorry, AxiosMockAdapter works too.

In example of README, MockAdapter is used.
So I thought AxiosMockAdapter was a wrong name, but both is fine.
https://github.com/ctimmerm/axios-mock-adapter?tab=readme-ov-file#example

@marcbachmann
Copy link
Collaborator

If you change all MockAdapter occurences to AxiosMockAdapter in the Readme and remove the webpack config change, I could approve the change 😉

@exoego exoego force-pushed the fix-AxiosMockAdapter branch from 734fee6 to 93d8398 Compare August 5, 2024 22:18
@exoego exoego changed the title fix: AxiosMockAdapter is no longer available doc: Use AxiosMockAdapter throughout README Aug 5, 2024
@exoego
Copy link
Contributor Author

exoego commented Aug 5, 2024

@marcbachmann I see. Fixed the PR.

@marcbachmann marcbachmann merged commit 2554141 into ctimmerm:master Aug 6, 2024
13 checks passed
@exoego exoego deleted the fix-AxiosMockAdapter branch August 6, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants