Allow for event weights when calculating percentile cuts #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 92.46% 92.62% +0.15%
==========================================
Files 49 49
Lines 2005 2048 +43
==========================================
+ Hits 1854 1897 +43
Misses 151 151
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
maxnoe
reviewed
May 25, 2023
| @@ -44,9 +92,14 @@ def calculate_percentile_cut( | |||
| min_events: int | |||
| Bins with less events than this number are replaced with ``fill_value`` | |||
| """ | |||
|
|
|||
| if weights is None: | |||
There was a problem hiding this comment.
I'd prefer it (and it's probably also faster) if the weights=None case would use the existing code instead of the weighted_quantile method with weights=1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request implementing issue #224 . Solution as described there, the weighted quantile function is custom.